Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dist files #224

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Conversation

ananyaarun
Copy link
Member

@ananyaarun ananyaarun commented Jul 3, 2019

Fixes #218

based on IS pr publiclab/image-sequencer#908

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@ananyaarun
Copy link
Member Author

@jywarren @sagarpreet-chadha as discussed in the call I have added dist to gitignore.

@sagarpreet-chadha
Copy link
Collaborator

Oh cool! Sorry i missed the call .
So how do we plan to 'grunt build' the dist ?
Will the maintainer do that before releasing new version ? Thanks!

@ananyaarun
Copy link
Member Author

According to me a developer can grunt build the dist files to run and test their changes locally (this has been added to readme)
And as you said perhaps the maintainer can do that before releasing a new version ?

@sagarpreet-chadha
Copy link
Collaborator

sagarpreet-chadha commented Jul 4, 2019

Okay great! @jywarren can we automate grunt build process prior to npm publish ? If yes, i would love to implement it if you can help :)

@jywarren
Copy link
Member

jywarren commented Jul 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow for managing dist files
3 participants