Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for managing dist files #218

Closed
ananyaarun opened this issue Jul 1, 2019 · 3 comments · Fixed by #224 or #228
Closed

Workflow for managing dist files #218

ananyaarun opened this issue Jul 1, 2019 · 3 comments · Fixed by #224 or #228

Comments

@ananyaarun
Copy link
Member

Description

Currently dist file are not in gitignore and hence huge lines of change needs to be merged in each PR. This leads to conflicts in dist files in other PR's etc. Dist files workflow are not very clear to a new comers and they usually get stuck with the grunt build step.

Solution

We can add dist to .gitignore
This has been done in IS repo here publiclab/image-sequencer#908

cc @sagarpreet-chadha @jywarren

@jywarren
Copy link
Member

jywarren commented Jul 5, 2019

Oops, did we start gitignoring the .css files too? Yes, but we didn't stop tracking them. So, for some reason we aren't seeing dist files from NPM anymore. Huh? Let me look, maybe npm is reading our gitignore?

@jywarren
Copy link
Member

jywarren commented Jul 5, 2019

Oops!

Use a .npmignore file to keep stuff out of your package. If there's no .npmignore file, but there is a .gitignore file, then npm will ignore the stuff matched by the .gitignore file. If you want to include something that is excluded by your .gitignore file, you can create an empty .npmignore file to override it.

So, ok i will override in this way. Opening a PR.

jywarren added a commit that referenced this issue Jul 5, 2019
@jywarren
Copy link
Member

jywarren commented Jul 5, 2019

#228

jywarren added a commit that referenced this issue Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants