Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dropdown Transitions #874

Closed
5 tasks
harshkhandeparkar opened this issue Mar 17, 2019 · 4 comments
Closed
5 tasks

Add Dropdown Transitions #874

harshkhandeparkar opened this issue Mar 17, 2019 · 4 comments
Labels
first-timers-only has-pull-request Issues which have a PR open

Comments

@harshkhandeparkar
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

To Do: Add a nice transition effect to the step collapse using bootstrap collapse plugin.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file defaultHtmlStepUi js in the image-sequencer repository (press the little pen Icon) and edit the line as shown below.

Change this code

$(step.ui.querySelector(".toggle")).on("click", () => {
$(step.ui.querySelector('.toggleIcon')).toggleClass('fa-caret-up').toggleClass('fa-caret-down');
$(step.ui.querySelectorAll(".cal")).toggleClass("collapse");
});

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

    $(step.ui.querySelector(".toggle")).on("click", () => {
      $(step.ui.querySelector('.toggleIcon')).toggleClass('fa-caret-up').toggleClass('fa-caret-down');
- $(step.ui.querySelectorAll(".cal")).toggleClass("collapse");
+ $(step.ui.querySelectorAll(".step")).collapse('toggle');
    });
  • 💾 Commit your changes.

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Mar 17, 2019

@mgroovyank do you want to solve this? This will be reserved to you for the next few days. If you don't reply or don't want to solve this one, ths can be assigned to someone else. But don't worry as new issues will be opened soon.
If someone wants to solve a first-timers-only issue but this one is taken up, join the discussion and add your name to the list in #842.

@An0u
Copy link

An0u commented Mar 18, 2019

I'd like to take this one up if it becomes available

@mgroovyank
Copy link
Member

@harshkhandeparkar I am doing this. Thank you.

@harshkhandeparkar
Copy link
Member Author

@mgroovyank awesome!! @An0u your name has been added to the list in #842

@harshkhandeparkar harshkhandeparkar added the has-pull-request Issues which have a PR open label Mar 18, 2019
This was referenced Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only has-pull-request Issues which have a PR open
Projects
None yet
Development

No branches or pull requests

3 participants