-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DrawRectangle info.json
causes JSON parse error during Travis CI test
#637
Comments
Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 |
GitMate.io thinks a possibly related issue is #51 (More Testing). |
1 similar comment
GitMate.io thinks a possibly related issue is #51 (More Testing). |
@vishalbakshi even I saw this, and solved this in #624 so when that PR gets merged, then this error will be solved! Thanks! |
My apologies, I did not see that! I will go ahead and close this issue. Thanks! |
Please describe the problem (or idea)
I made a commit related to PR #584 and node threw an error during one of the Travis CI build tests.
I did not expect to see this error during the Travis CI build tests since it is related to a file that I did not commit.
Please show us where to look
The error thrown during Travis' build test can be seen here:
https://travis-ci.org/publiclab/image-sequencer/jobs/477001494#L1713
In the following file (modules/DrawRectangle/info.json), I think the comma in the highlighted line is causing the JSON parsing error:
image-sequencer/src/modules/DrawRectangle/info.json
Line 40 in e5d2681
I believe this issue can be fixed by either removing the comma or adding an "outputs" property as outlined in the following from CONTRIBUTING.md
https://github.com/publiclab/image-sequencer/blob/master/CONTRIBUTING.md#info-file
Browser, version, and operating system
Browser/version: Google Chrome/Version 71.0.3578.98 (Official Build) (64-bit)
OS: macOS High Sierra 10.13.4
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
The text was updated successfully, but these errors were encountered: