Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawRectangle info.json causes JSON parse error during Travis CI test #637

Closed
vishalbakshi opened this issue Jan 9, 2019 · 5 comments
Closed
Labels
bug module New Module idea

Comments

@vishalbakshi
Copy link

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

I made a commit related to PR #584 and node threw an error during one of the Travis CI build tests.

What did you expect to see that you didn't?

I did not expect to see this error during the Travis CI build tests since it is related to a file that I did not commit.

Please show us where to look

The error thrown during Travis' build test can be seen here:
https://travis-ci.org/publiclab/image-sequencer/jobs/477001494#L1713

In the following file (modules/DrawRectangle/info.json), I think the comma in the highlighted line is causing the JSON parsing error:

I believe this issue can be fixed by either removing the comma or adding an "outputs" property as outlined in the following from CONTRIBUTING.md

https://github.com/publiclab/image-sequencer/blob/master/CONTRIBUTING.md#info-file

Browser, version, and operating system

Browser/version: Google Chrome/Version 71.0.3578.98 (Official Build) (64-bit)
OS: macOS High Sierra 10.13.4


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@gitmate gitmate bot added the module New Module idea label Jan 9, 2019
@welcome
Copy link

welcome bot commented Jan 9, 2019

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@gitmate
Copy link

gitmate bot commented Jan 9, 2019

GitMate.io thinks a possibly related issue is #51 (More Testing).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jan 9, 2019

GitMate.io thinks a possibly related issue is #51 (More Testing).

@gitmate gitmate bot added the bug label Jan 9, 2019
@Mridul97
Copy link

Mridul97 commented Jan 9, 2019

@vishalbakshi even I saw this, and solved this in #624 so when that PR gets merged, then this error will be solved! Thanks!

@vishalbakshi
Copy link
Author

My apologies, I did not see that! I will go ahead and close this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module New Module idea
Projects
None yet
Development

No branches or pull requests

2 participants