Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to export edge-detected image with black background #176

Closed
2 tasks
tech4GT opened this issue Feb 16, 2018 · 6 comments
Closed
2 tasks

Add option to export edge-detected image with black background #176

tech4GT opened this issue Feb 16, 2018 · 6 comments

Comments

@tech4GT
Copy link
Member

tech4GT commented Feb 16, 2018

Desired output

  • Export image with black background
  • Add support for jpeg images
@jywarren
Copy link
Member

This is a follow-up to #168 !! Thanks!

@Ankit-Singla
Copy link

Ankit-Singla commented Oct 5, 2018

Hi,
Is this issue still open?
If so, I would like to work on this one if it's okay?

@tech4GT
Copy link
Member Author

tech4GT commented Oct 5, 2018

@Ankit-Singla this is a relatively difficult issue, we would love your help here though!! Don't hesitate to ask if you get stuck! Thanks!!

@Ankit-Singla
Copy link

I was thinking to present it as an input to the user, whether he/she wants the background to be white or black in the existing 'Detect Edges' module. Does this seem fine, or should I integrate this alternatively. @tech4GT
Thanks

@tech4GT
Copy link
Member Author

tech4GT commented Oct 5, 2018

@Ankit-Singla Taking an option will be nicer! Thanks!!

@harshkhandeparkar
Copy link
Member

@tech4GT @jywarren I am working on this (almost done). I'm actually going to complete the module with hysterisis. I think I have found out a pretty good way of doing that. The black background is working. Just a few more lines of code needed to complete hysterisis. Will open a pr soon 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants