Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Close" button doesn't close "Take a photo" box #1409

Closed
tsparksh opened this issue Jan 2, 2020 · 7 comments · May be fixed by #1412
Closed

"Close" button doesn't close "Take a photo" box #1409

tsparksh opened this issue Jan 2, 2020 · 7 comments · May be fixed by #1412

Comments

@tsparksh
Copy link
Member

tsparksh commented Jan 2, 2020

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

When a camera is not connected, we can't close "Take a photo" box
takeaphoto

Can we fix this?

Please show us where to look

https://beta.sequencer.publiclab.org

@ataata107
Copy link

Can I claim this?

@tsparksh
Copy link
Member Author

tsparksh commented Jan 2, 2020

Can I claim this?

Sure, but it is not a GCI task

@root00198
Copy link
Member

root00198 commented Jan 2, 2020

I was kind of already working on it... Did mentioned because didn't felt necessary(my mistake).... The bug is resolved though, should I create a PR??

@ataata107
Copy link

Wow, I also happened to solve it. I don't have any problem if you create a PR but do claim it (obviously necessary) as others who claim it might have also given time to it.

@root00198
Copy link
Member

Nah, you do it. Its yours...

@ataata107
Copy link

Ah Cool, Maybe you can work on #1411 if moderators find the issue suitable

@harshkhandeparkar
Copy link
Member

Related to #1412. Will get fixed upon fixing #1412.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants