Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a linting tool #502

Closed
keshav234156 opened this issue May 6, 2020 · 3 comments · Fixed by #519
Closed

Adding a linting tool #502

keshav234156 opened this issue May 6, 2020 · 3 comments · Fixed by #519

Comments

@keshav234156
Copy link
Member

Eslint and Husky:
Eslint is a tool for identifying and reporting patterns faced in ECMAScript/JavaScript Code,with the goal of making the code more consistent. In order to force the contributor to use Eslint before they commit their code we will use Husky

Eslint and Husky where previously used in Image-Sequencer project. We can think of other alternative tools if it doesn't work here.

@govindgoel
Copy link
Member

govindgoel commented May 18, 2020

This is great but I suggest that we can also add Lint-Staged as it can check staged files only and later we require to only lint the files that will be committed. Feel free to comment, Thanks.

@jywarren
Copy link
Member

jywarren commented Jun 2, 2020

Ooh this is cool. Thanks @govindgoel for the input too!

@emilyashley
Copy link
Member

I was adding comments on the PR, but wondering if I should post them here instead?

This is definitely a good part of Step 2 in our Collaboration doc!

  1. What would we like as developers to safely change (i.e. conversely what NOT to break!) and develop on the project? (testing, issue templates? CI, github milestones/projects etc)

🎉🎉🎉

And I'd love to get the whole team's buy in on the tools we use especially if they're saved as part of the project in version control. cc: @Shulammite-Aso @Shreyaa-s @NitinBhasneria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants