From 87fe363d2897861d5c8738795f9fdecb90c205bb Mon Sep 17 00:00:00 2001 From: alex_ Date: Thu, 5 Dec 2024 11:43:32 +0100 Subject: [PATCH 01/16] changes kol-span-ws to kol-span Refs: #7035 --- .../src/components/details/style.scss | 10 ++- packages/components/src/components/link.scss | 12 ++- packages/components/src/components/style.scss | 27 +++--- .../src/components/tree-item/style.scss | 2 +- .../Collapsible/collapsible.scss | 6 +- .../src/functional-components/Span/Span.tsx | 2 +- .../Span/SpanCoreHelper.tsx | 2 +- .../Span/test/snapshot.test.tsx | 2 +- .../default/src/components/accordion.scss | 14 +-- .../default/src/components/details.scss | 6 +- .../default/src/components/link-button.scss | 86 +++++++++---------- .../default/src/components/skip-nav.scss | 2 +- .../default/src/components/split-button.scss | 6 +- .../themes/default/src/components/tabs.scss | 6 +- packages/themes/default/src/global.scss | 4 +- packages/themes/default/src/mixins/link.scss | 4 +- .../ecl/src/ecl-ec/components/details.scss | 4 +- .../themes/ecl/src/ecl-ec/components/nav.scss | 16 ++-- .../ecl/src/ecl-ec/components/skip-nav.scss | 2 +- .../src/ecl-ec/components/split-button.scss | 4 +- .../ecl/src/ecl-ec/components/tabs.scss | 8 +- packages/themes/ecl/src/ecl-ec/global.scss | 4 +- .../ecl/src/ecl-eu/components/details.scss | 4 +- .../src/ecl-eu/components/link-button.scss | 72 ++++++++-------- .../themes/ecl/src/ecl-eu/components/nav.scss | 10 +-- .../ecl/src/ecl-eu/components/skip-nav.scss | 2 +- .../ecl/src/ecl-eu/components/tabs.scss | 8 +- packages/themes/ecl/src/ecl-eu/global.scss | 4 +- .../itzbund/src/components/details.scss | 2 +- .../themes/itzbund/src/components/nav.scss | 2 +- .../itzbund/src/components/skip-nav.scss | 2 +- .../itzbund/src/components/split-button.scss | 10 +-- .../themes/itzbund/src/components/tabs.scss | 2 +- packages/themes/itzbund/src/global.scss | 4 +- packages/themes/itzbund/src/mixins/link.scss | 4 +- 35 files changed, 185 insertions(+), 170 deletions(-) diff --git a/packages/components/src/components/details/style.scss b/packages/components/src/components/details/style.scss index 89e07e8734..66e003b854 100644 --- a/packages/components/src/components/details/style.scss +++ b/packages/components/src/components/details/style.scss @@ -14,11 +14,13 @@ button { min-height: auto; - } - button .kol-span-wc .span-label { - border-bottom-color: grey; - border-bottom-style: solid; + .kol-span { + .&__label { + border-bottom-color: grey; + border-bottom-style: solid; + } + } } } diff --git a/packages/components/src/components/link.scss b/packages/components/src/components/link.scss index 7656e3fe54..b6676c4981 100644 --- a/packages/components/src/components/link.scss +++ b/packages/components/src/components/link.scss @@ -14,15 +14,19 @@ text-align: left; text-decoration-line: none; - .kol-span-wc .span-label { - text-decoration-line: underline; + .kol-span { + .&__label { + text-decoration-line: underline; + } } } a:is(:focus, :hover):not([aria-disabled]), button:is(:focus, :hover):not([disabled]) { - .kol-span-wc .span-label { - text-decoration-thickness: 0.2em; + .kol-span { + .&__label { + text-decoration-thickness: 0.2em; + } } } diff --git a/packages/components/src/components/style.scss b/packages/components/src/components/style.scss index 022fd4fc26..6ce76845ab 100644 --- a/packages/components/src/components/style.scss +++ b/packages/components/src/components/style.scss @@ -17,16 +17,15 @@ box-sizing: border-box; } - /* KolSpan is a layout component with icons in all directions and a label text in the middle. */ - .kol-span-wc { + .kol-span { + /* KolSpan is a layout component with icons in all directions and a label text in the middle. */ display: grid; place-items: center; - } - - /* The sub span in KolSpan is the horizontal span with icon left and right and the label text in the middle. */ - .kol-span-wc > span { - display: flex; - place-items: center; + /* The sub span in KolSpan is the horizontal span with icon left and right and the label text in the middle. */ + &__container { + display: flex; + place-items: center; + } } a, @@ -35,8 +34,12 @@ } /* This is the text label. */ - .hide-label > .kol-span-wc > span > span { - display: none; + .hide-label { + .kol-span { + &__label { + display: none; + } + } } /* Reset browser agent style. */ @@ -55,8 +58,8 @@ outline: none; } - [aria-disabled='true']:focus .kol-span-wc, - [disabled]:focus .kol-span-wc { + [aria-disabled='true']:focus .kol-span, + [disabled]:focus .kol-span { outline: none !important; } } diff --git a/packages/components/src/components/tree-item/style.scss b/packages/components/src/components/tree-item/style.scss index cd4d7b0076..213527c1b2 100644 --- a/packages/components/src/components/tree-item/style.scss +++ b/packages/components/src/components/tree-item/style.scss @@ -25,7 +25,7 @@ } } - a .kol-span-wc { + a .kol-span { place-items: unset; // unset 'center' style from global layer } } diff --git a/packages/components/src/functional-components/Collapsible/collapsible.scss b/packages/components/src/functional-components/Collapsible/collapsible.scss index 0b2e54e0ba..33e7e1547a 100644 --- a/packages/components/src/functional-components/Collapsible/collapsible.scss +++ b/packages/components/src/functional-components/Collapsible/collapsible.scss @@ -44,8 +44,10 @@ * Inside a button, the caption text is always centered. * So we have to align the text to the left. */ - &__heading-button button .kol-span-wc { - justify-items: start; + &__heading-button button { + .kol-span { + justify-items: start; + } } } } diff --git a/packages/components/src/functional-components/Span/Span.tsx b/packages/components/src/functional-components/Span/Span.tsx index c8a3deaf67..b08d69eb2e 100644 --- a/packages/components/src/functional-components/Span/Span.tsx +++ b/packages/components/src/functional-components/Span/Span.tsx @@ -37,7 +37,7 @@ const KolSpanFc: FC = (props, children) => { } return ( - + {isObject(topIconProps) && } {isObject(leftIconProps) && } diff --git a/packages/components/src/functional-components/Span/SpanCoreHelper.tsx b/packages/components/src/functional-components/Span/SpanCoreHelper.tsx index d61df0af0d..df703daccd 100644 --- a/packages/components/src/functional-components/Span/SpanCoreHelper.tsx +++ b/packages/components/src/functional-components/Span/SpanCoreHelper.tsx @@ -13,7 +13,7 @@ const KolSpanCoreHelperFc: FC<{ label: string; hideLabel?: boolean; badgeText?: return ( <> {hideExpertSlot && } -