Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore only respects the root gitignore #1730

Closed
max-sixty opened this issue Sep 29, 2020 · 2 comments · Fixed by #2225
Closed

gitignore only respects the root gitignore #1730

max-sixty opened this issue Sep 29, 2020 · 2 comments · Fixed by #2225
Assignees
Labels
C: file collection Related to file collection (e.g. gitignore & cache) or file discovery and all of its configuration. S: accepted The changes in this design / enhancement issue have been accepted and can be implemented T: enhancement New feature or request

Comments

@max-sixty
Copy link

Is your feature request related to a problem? Please describe.

This is fairly narrow, and would be understandable if it weren't worth fixing, but posting regardless.

Currently black only respects the root .gitignore to ignore files (#475). So a path like:

project
|-.gitignore <- doesn't contain .terraform
|-python-project
|-infra
  |-.gitignore # <- contains .terraform
  |-.terraform
    |-module.py

...will still format module.py

Describe the solution you'd like

Apply .gitignore rules like git does


Thanks as ever for the superb library!

@hadialqattan
Copy link
Contributor

Hi, I'm working on that, can anyone assign this issue to me?

@JulianVolodia

This comment has been minimized.

@ichard26 ichard26 added C: file collection Related to file collection (e.g. gitignore & cache) or file discovery and all of its configuration. S: accepted The changes in this design / enhancement issue have been accepted and can be implemented labels May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: file collection Related to file collection (e.g. gitignore & cache) or file discovery and all of its configuration. S: accepted The changes in this design / enhancement issue have been accepted and can be implemented T: enhancement New feature or request
Projects
None yet
4 participants