[FR] increasing ps2rd cheats limit

[AfterDyons]

Checks

• I have checked existing OPL feature requests for duplicates and found none

Describe the FR

Now ps2rd can load only 255 lines of cheats excluding description and blank lines.

Describe the solution you'd like

Can this limit be increased to 510 lines?

Describe alternatives you've considered

No response

Additional context

No response

[israpps]

https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/include/cheatman.h#L39-L41

According to these macros MAX_CHEATLIST should yield 510

and since OPL uses a uni-dimensional array for storing both value and adress it's 255 as you say

Maybe @AKuHAK or @uyjulian knows if setting larger values to MAX_CODES is safe

[Aced14]

Back in 2014 I sent over a PR in OPL's Bitbucket repo to increase PS2RD's cheat line limit from 100 to 500. My goal was to put OPL on par with ps2rdmod's 500 line limit.

IIRC @sp193 reviewed the PR and expressed concerns about supporting 500 lines. We subsequently compromised at 250. I think his line of thinking at the time was that he didn't want PS2RD gobbling up too much of OPL's memory. Not sure if memory usage is still as big of a concern nowadays though given how newer official OPL builds seem to have taken the approach of pre-enabling just about every formerly-optional feature (e.g. PS2RD, GSM, PADEMU, IGS, etc...).

Unfortunately I don't think the Bitbucket PR exists anymore. Bitbucket's mercurial repos were decommissioned years ago and it doesn't look like the Wayback Machine managed to mirror the PR.

PS:
Cheat Device for PS2 currently uses the same code line limits as OPL's PS2RD implementation. Although issues like root670/CheatDevicePS2#43 are pushing to increase its limit too.

[israpps]

I got interested in this feature request because I'm handling a widescreen cheats archive

And two cheats for games of the Jack and Daxter series seem to have cheats specific to every word of the game, and the amount of cheats surpassed 300