Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically determine :ssl based on connection uri #133

Open
reify-james-vickers opened this issue May 6, 2022 · 2 comments
Open

Automatically determine :ssl based on connection uri #133

reify-james-vickers opened this issue May 6, 2022 · 2 comments

Comments

@reify-james-vickers
Copy link
Contributor

protojure.grpc.client.providers.http2/connect takes a map that must contain :uri and can optionally contain :ssl with boolean value. It seems possible to automatically know that SSL should be used if the uri starts with https:// which is defining the connection scheme as HTTPS/SSL. Would it be possible to not have to provide :ssl in such cases then?

@ghaskins
Copy link
Member

ghaskins commented May 7, 2022

Yes, definitely possible. The ssl field should remain for backwards compat, but we could make it have a default based on the scheme. I would consider a PR that implements this.

@reify-james-vickers
Copy link
Contributor Author

#136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants