Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - fix grammar for time-based decisions #353

Closed
maxholloway opened this issue Aug 31, 2022 · 2 comments
Closed

Suggestion - fix grammar for time-based decisions #353

maxholloway opened this issue Aug 31, 2022 · 2 comments

Comments

@maxholloway
Copy link

Hi! Tiny nit-pick here, nbd if it doesn't get fixed.

When including timestamps in contracts, you get the following warning.

warning  Avoid to make time-based decisions in your business logic  not-rely-on-time

Would we fix the grammar to say the following?

warning  Avoid making time-based decisions in your business logic  not-rely-on-time

Again, not a big deal, but it should be a super straightforward change in these files:

Otherwise, I've had a great experience using the tool! Thanks folks.

@MCarlomagno
Copy link
Contributor

I just created a PR for this one

@dbale-altoros
Copy link
Collaborator

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants