Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2008 build issue with protobuf 3.5.0 #4064

Closed
jakirkham opened this issue Dec 19, 2017 · 3 comments
Closed

VS2008 build issue with protobuf 3.5.0 #4064

jakirkham opened this issue Dec 19, 2017 · 3 comments

Comments

@jakirkham
Copy link

jakirkham commented Dec 19, 2017

Ran into the following issue when trying to build protobuf 3.5.0 where map::at was used. The map::at method only exists in C++11. As such it cannot compile with a non-C++11 compiler like VS2008.

C:\bld\protobuf_1513642428254\work\protobuf-3.5.0\src\google\protobuf\util\field_mask_util.cc(377) : error C2039: 'at' : is not a member of 'std::map<_Kty,_Ty>'
        with
        [
            _Kty=std::string,
            _Ty=google::protobuf::util::`anonymous-namespace'::FieldMaskTree::Node *
        ]
NMAKE : fatal error U1077: 'C:\PROGRA~2\MICROS~1.0\VC\bin\cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe"' : return code '0x2'
Stop.

ref: https://ci.appveyor.com/project/conda-forge/protobuf-feedstock/build/job/o85bad6hfjhvyxvu

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Dec 19, 2017

We will release 3.5.1 very soon. Could you help make a pull request to fix this in the 3.5.x branch?

@pherl is working on 3.5.1 release.

@jakirkham
Copy link
Author

PR ( #4074 ) fixed this issue.

@jakirkham
Copy link
Author

Should add that when trying to build protobuf with that patch ran into issue ( #4075 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants