Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IPFS 0.6.x #1283

Closed
odisseus opened this issue Apr 21, 2020 · 2 comments
Closed

Support for IPFS 0.6.x #1283

odisseus opened this issue Apr 21, 2020 · 2 comments
Assignees
Labels
good first issue Good for newcomers installer Relates to the installation of Fury ipfs Relates to integration with IPFS
Milestone

Comments

@odisseus
Copy link
Collaborator

The latest version of IPFS allows to use its HTTP API only with the POST method (see ipfs/kubo#7097). Attempting to use current builds of Fury with this version of the IPFS daemon results in exceptions like this one:

An unexpected error occurred:
  java.lang.RuntimeException: IOException contacting IPFS daemon.
  Trailer: null 405 - Method Not Allowed
  
      at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1900)
      at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
      at io.ipfs.api.IPFS.get(IPFS.java:682)
      at io.ipfs.api.IPFS.retrieve(IPFS.java:675)
      at io.ipfs.api.IPFS.retrieveAndParse(IPFS.java:637)
      at io.ipfs.api.IPFS.version(IPFS.java:585)
      at io.ipfs.api.IPFS.<init>(IPFS.java:71)
      at io.ipfs.api.IPFS.<init>(IPFS.java:47)

This change doesn't require any changes in the Fury code, but the java-ipfs-http-client library will have to be updated as soon as the new approach is implemented (see ipfs-shipyard/java-ipfs-http-client#157).

@odisseus odisseus self-assigned this Apr 21, 2020
@odisseus odisseus added the ipfs Relates to integration with IPFS label Apr 21, 2020
@propensive
Copy link
Owner

It's been quite a while since the last release. I wonder if it fixes any other issues...

@propensive propensive added the installer Relates to the installation of Fury label May 4, 2020
@propensive propensive added this to the Alecto milestone May 4, 2020
@propensive propensive added the good first issue Good for newcomers label May 7, 2020
@propensive propensive linked a pull request May 8, 2020 that will close this issue
@odisseus odisseus changed the title Support for IPFS 0.5.x Support for IPFS 0.6.x Jul 2, 2020
@odisseus
Copy link
Collaborator Author

odisseus commented Jul 2, 2020

Looks like there are no breaking changes between versions 0.5.1 and 0.6.0.

@odisseus odisseus closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers installer Relates to the installation of Fury ipfs Relates to integration with IPFS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants