Convert to CircleCI for build testing #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Travis with CircleCI for testing. Fixes: #229 Signed-off-by: SuperQ <superq@gmail.com>
|
Legend. Thank you so much for the extremely quick response!! |
dmagliola
approved these changes
Jun 20, 2021
|
I would double check to make sure everything is working as expected. I noticed some coveralls errors in the CI output. |
|
Yeah, I can take a look at that. The crucial bit for me what the part I didn't have permissions for, which you've done. |
dmagliola
added a commit
that referenced
this pull request
Jan 7, 2022
We've been having errors in CI from Coveralls, when trying to upload results. (As mentioned in [this comment](#230 (comment))) This error seems to be because our coveralls gem is pretty old and abandoned, and probably using a TLS version that is no longer supported. (Reference: lemurheavy/coveralls-ruby#163) One option recommended in that issue is to switch to a different `coveralls-ruby-reborn` gem. However, given that we only use `coveralls` to upload results to the cloud, only so we can have a badge in our README reporting 100%, in the interest of security, I think i'd rather get rid of `coveralls` altogether, and use `simplecov` directly instead, which reports the coverage when running the tests and doesn't upload them anywhere.
dmagliola
added a commit
that referenced
this pull request
Jan 7, 2022
We've been having errors in CI from Coveralls, when trying to upload results. (As mentioned in [this comment](#230 (comment))) This error seems to be because our coveralls gem is pretty old and abandoned, and probably using a TLS version that is no longer supported. (Reference: lemurheavy/coveralls-ruby#163) One option recommended in that issue is to switch to a different `coveralls-ruby-reborn` gem. However, given that we only use `coveralls` to upload results to the cloud, only so we can have a badge in our README reporting 100%, in the interest of security, I think i'd rather get rid of `coveralls` altogether, and use `simplecov` directly instead, which reports the coverage when running the tests and doesn't upload them anywhere. Signed-off-by: Daniel Magliola <dmagliola@crystalgears.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Travis with CircleCI for testing.
Signed-off-by: SuperQ superq@gmail.com