Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis -> CircleCI #133

Closed
lawrencejones opened this issue Jun 16, 2019 · 6 comments
Closed

Travis -> CircleCI #133

lawrencejones opened this issue Jun 16, 2019 · 6 comments

Comments

@lawrencejones
Copy link
Contributor

Travis has gone through some unfortunate times recently and CircleCI offer a more comprehensive and flexible configuration in their V2 spec.

It could be good to run CI like this: https://github.com/gocardless/statesman/blob/master/.circleci/config.yml

@Sinjo
Copy link
Member

Sinjo commented Oct 5, 2019

Would love to have a crack at this, but it looks like I need repo admin to get started.

Screenshot 2019-10-05 at 14 30 05

@SuperQ would you be able to help with that when you have a minute?

@Sinjo
Copy link
Member

Sinjo commented Mar 23, 2021

@SuperQ Just running through old issues and I'd like to give this one a go. Figure it makes sense for the reasons outlined by @lawrencejones and the fact that prometheus/prometheus uses CircleCI too.

Any chance I could (at least temporarily) be made admin on this repo?

@dmagliola
Copy link
Collaborator

Looking at the other repos, it looks like they also use Circle, so this'd make sense to me

@dmagliola
Copy link
Collaborator

I wonder, however, if it'd make more sense to use the "Matrix" feature, like the Python repo does, instead of specifying the different versions like in Lawrence's proposal.

Although that's a nitpick, and I may be over-reading on what he was proposing to do

@Sinjo
Copy link
Member

Sinjo commented Mar 24, 2021

I don't think Lawrence was being that specific about what Circle config we write as much as saying that we should move over to Circle. Not least because they added build matrices almost a year after he raised this issue.

@Sinjo
Copy link
Member

Sinjo commented Jan 25, 2022

Closing this as it's been done in #230.

@Sinjo Sinjo closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants