Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of this project #109

Open
prolic opened this issue Sep 13, 2023 · 4 comments
Open

Maintenance of this project #109

prolic opened this issue Sep 13, 2023 · 4 comments
Assignees

Comments

@prolic
Copy link
Owner

prolic commented Sep 13, 2023

There are a few problems with this project at the moment:

I don't use this library at my work or hobby projects at the moment, so I have no personal urge to push this forward and make it up to date. However I would feel sad for others who like this project and want to continue using it. I tried to invest an hour today and see how far I get it within that hour, but I ran immediately into issues just running the existing test suite on PHP 8.2 using amqp extension version 2.1. This was my output:

EEEEEEEEEEEEEEE...............EE..E.........EE..........

it just hangs after that. Going into debug mode, I can see the tests hang at

Test 'HumusTest\Amqp\AmqpExtension\JsonRpc\JsonRpcClientAndServerTest::it_sends_requests_and_server_responds' started.

According to packagist.org statistics, as of this writing, this package has overall 148663 downloads with 2591 downloads in the last month alone.

I would love to see some previous contributors step up and work together on a 2.2 (or name it 3.0) version of this library. I'm certainly still willing to do code reviews or give suggestions where I can, but I don't want to spend countless unpaid hours on a project that I don't use anymore.

I hope maybe @basz, @func0der or @thomasvargiu maybe have the time and will to help out here, otherwise I may decide to abandon this project (and maybe revive it later if need may arise for me again).

@prolic prolic self-assigned this Sep 13, 2023
@prolic
Copy link
Owner Author

prolic commented Sep 13, 2023

Also tagging @lost-anjarrett.

@basz
Copy link
Collaborator

basz commented Sep 13, 2023

understandable.
i can try to step up here. I'll start by ditching travis in favor gh actions

@olekhy
Copy link

olekhy commented Sep 14, 2023

@prolic Certainly, you can communicate to the community that the PHP version should not exceed 8.0 or 8.1 by specifying the PHP version constraint in the composer.json file. To do this, you can add the following to your composer.json file:

"require": {
        "php": "^7.4 || 8.0.* || 8.1.*",
}        

explain:
To ensure that only versions in the 8.0.x format are installed in Composer and that version 8.1.0 is not allowed, you can use the wildcard operator. In your Composer JSON file, it would look like this:

"require": {
    "package-name": "8.0.*"
}

With this specification, Composer is instructed to only install versions of "package-name" in the 8.0.x format, where "x" represents any minor version. This means that versions like 8.0.1, 8.0.2, and so on can be installed, but 8.1.0 or 8.1.x will not be installed.

@basz
Copy link
Collaborator

basz commented Sep 16, 2023

hi @lost-anjarrett @func0der @thomasvargiu

#110 could use some eyes on the last failing (skipped for now) test.

https://github.com/basz/HumusAmqp/actions

@basz basz pinned this issue Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants