Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Tutorial Typo/Error #1477

Closed
Ghabri-EL opened this issue Oct 26, 2022 · 2 comments
Closed

Advanced Tutorial Typo/Error #1477

Ghabri-EL opened this issue Oct 26, 2022 · 2 comments
Assignees
Milestone

Comments

@Ghabri-EL
Copy link

In the advanced tutorial, when creating the custom histogram class in HistogramModel.js file, creating chart variable and defining it as constant promps issues with the reset method, as the reset method tries to change the chart variable by creating a new Chart object.

https://mesa.readthedocs.io/en/latest/tutorials/adv_tutorial.html#id5
typo png

@rht
Copy link
Contributor

rht commented Oct 27, 2022

That reset code in the advanced tutorial seems outdated. The reset in the actual implementation in library has been changed in this commit. It's unclear how the change fixed the supposed bug.

And the new code could have been made clearer too. According to https://stackoverflow.com/questions/1232040/how-do-i-empty-an-array-in-javascript

chart.data.labels = [];

would have worked. But this needs testing.

@tpike3 tpike3 self-assigned this Jan 8, 2023
@tpike3 tpike3 added this to the Mesa 2.0 milestone Jan 8, 2023
@tpike3 tpike3 added the Sprints! A task that might be good to tackle during sprints! label Apr 16, 2023
@tpike3 tpike3 modified the milestones: Mesa 2.0, ReadtheDocs Jun 18, 2023
@jackiekazil jackiekazil removed the Sprints! A task that might be good to tackle during sprints! label May 17, 2024
@quaquel quaquel closed this as completed Oct 30, 2024
@quaquel quaquel reopened this Oct 30, 2024
@quaquel
Copy link
Member

quaquel commented Oct 30, 2024

has become outdated because the docs etc. have changed a lot

@quaquel quaquel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants