Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

favicon: automatically detect favicons & calculate mmh3 #498

Closed
nil0x42 opened this issue Jan 14, 2022 · 0 comments · Fixed by #528 or #532
Closed

favicon: automatically detect favicons & calculate mmh3 #498

nil0x42 opened this issue Jan 14, 2022 · 0 comments · Fixed by #528 or #532
Assignees
@LuitelSamikshya
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
v1.2.0

Comments

@nil0x42
Copy link

nil0x42 commented Jan 14, 2022

The new -favicon feature is interesting.

Therefore, it would be great if httpx could automatically add favicon-mmh3 to json output if received response's content-type is image/x-icon. without having to explicitly add -favicon command-line option.

It would make easier to scan for both normal URLs & favicons in the same instance

for example:
list.txt

google.com
google.com.favicon.ico
duckduckgo.com
duckduckgo.com/favicon.ico

< list.txt httpx -json
@nil0x42 nil0x42 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 14, 2022
@ehsandeep ehsandeep added the Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix label Jan 27, 2022
@LuitelSamikshya LuitelSamikshya self-assigned this Feb 18, 2022
@LuitelSamikshya LuitelSamikshya linked a pull request Feb 18, 2022 that will close this issue
detect favicon #521
Closed
@LuitelSamikshya LuitelSamikshya added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Feb 18, 2022
@ehsandeep ehsandeep added Status: Abandoned This issue is no longer important to the requestor and no one else has shown an interest in it. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Feb 24, 2022
@ehsandeep ehsandeep removed a link to a pull request Feb 24, 2022
detect favicon #521
Closed
@ehsandeep ehsandeep linked a pull request Mar 1, 2022 that will close this issue
hash improvement #528
Merged
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Abandoned This issue is no longer important to the requestor and no one else has shown an interest in it. labels Mar 1, 2022
@ehsandeep ehsandeep added this to the v1.2.0 milestone Mar 1, 2022
@ehsandeep ehsandeep linked a pull request Mar 1, 2022 that will close this issue
v1.2.0 Release #532
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

hash improvement projectdiscovery/httpx
v1.2.0 Release projectdiscovery/httpx
3 participants
@nil0x42 @ehsandeep @LuitelSamikshya