Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rate limit per minute (rlm) support #442

Closed
inthenightsky opened this issue Nov 25, 2021 · 1 comment · Fixed by #490 or #532
Closed

Implement rate limit per minute (rlm) support #442

inthenightsky opened this issue Nov 25, 2021 · 1 comment · Fixed by #490 or #532
Assignees
@LuitelSamikshya
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
v1.2.0

Comments

@inthenightsky
Copy link

Please describe your feature request:

In line with Nuclei's configuration options, implement the -rlm flag which will allow users to rate limit per minute, rather than solely on a per-second basis.

Describe the use case of this feature:

Where a bug bounty program specifies rate limiting on a per-minute basis rather than per-second, it could be handy. It would also bring alignment to other projects where this option exists.
@inthenightsky inthenightsky added the Type: Enhancement Most issues will probably ask for additions or changes. label Nov 25, 2021
@ehsandeep ehsandeep added the Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix label Nov 27, 2021
@ehsandeep ehsandeep changed the title Implement -rlm flag Implement rate limit per minute (rlm) support Nov 27, 2021
@ehsandeep
Copy link
Member

Related PR in nuclei - projectdiscovery/nuclei#896

@ehsandeep ehsandeep added this to the v1.1.5 milestone Dec 19, 2021
@ehsandeep ehsandeep removed this from the v1.1.5 milestone Jan 10, 2022
@LuitelSamikshya LuitelSamikshya self-assigned this Jan 11, 2022
@LuitelSamikshya LuitelSamikshya linked a pull request Jan 11, 2022 that will close this issue
ratelimit per min support #490
Merged
@LuitelSamikshya LuitelSamikshya added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 11, 2022
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 13, 2022
@ehsandeep ehsandeep added this to the v1.2.0 milestone Mar 1, 2022
@ehsandeep ehsandeep linked a pull request Mar 1, 2022 that will close this issue
v1.2.0 Release #532
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

ratelimit per min support projectdiscovery/httpx
v1.2.0 Release projectdiscovery/httpx
3 participants
@ehsandeep @inthenightsky @LuitelSamikshya