Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple comma separated values / file for allow / deny flag #374

Closed
ehsandeep opened this issue Aug 22, 2021 · 0 comments · Fixed by #376 or #370
Closed

Support for multiple comma separated values / file for allow / deny flag #374

ehsandeep opened this issue Aug 22, 2021 · 0 comments · Fixed by #376 or #370
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@ehsandeep
Copy link
Member

Is your feature request related to a problem? Please describe.
httpx supports allow/deny flag to define IPs/CIDRs to process, currently, it's limited to a single value per flag, for passing multiple values, the same flag needs to be used multiple times, this support can be enhanced by adding comma-separated values or file as if possible with the same flag.

We have similar support in dnsx for r flag to feed file or multiple comma-separated values.

  -r string
    	List of resolvers (file or comma separated)

Describe the solution you'd like

echo http://localhost | httpx -probe -deny 127.0.0.0/8,10.0.0.0/8,1.1.1.1
echo http://localhost | httpx -probe -allow 127.0.0.0/8,10.0.0.0/8,1.1.1.1
echo http://localhost | httpx -probe -allow allow-list.txt
echo http://localhost | httpx -probe -deny deny-list.txt

Related issue:- #371

@ehsandeep ehsandeep added the Type: Enhancement Most issues will probably ask for additions or changes. label Aug 22, 2021
@Mzack9999 Mzack9999 linked a pull request Aug 22, 2021 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Aug 24, 2021
@ehsandeep ehsandeep linked a pull request Aug 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
2 participants