Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-Length in HEAD method #348

Closed
puckk opened this issue Aug 9, 2021 · 4 comments · Fixed by #369 or #370
Closed

Content-Length in HEAD method #348

puckk opened this issue Aug 9, 2021 · 4 comments · Fixed by #369 or #370
Assignees
@Mzack9999
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@puckk
Copy link

puckk commented Aug 9, 2021 •
edited by ehsandeep
Loading

Describe the bug
When using the request method, upper case input is not properly handled.

echo hackerone.com | httpx -x head -content-length -silent
https://hackerone.com [155]

echo hackerone.com | httpx -x HEAD -content-length -silent
https://hackerone.com [0]

Environment details

httpx -v1.1.0
@ehsandeep
Copy link
Member

@puckk may be related to upper/lower case handling, working fine with lowercase.

echo hackerone.com | httpx -x head -content-length -silent
https://hackerone.com [155]

@puckk
Copy link
Author

puckk commented Aug 9, 2021

Oh my bad. Thanks!

@puckk puckk closed this as completed Aug 9, 2021
@ehsandeep
Copy link
Member

No problem, instead, let me reopen this ticket to include support for both scenarios.

@ehsandeep ehsandeep reopened this Aug 9, 2021
@ehsandeep ehsandeep added Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Aug 9, 2021
@ehsandeep
Copy link
Member

@puckk I've updated the issue with details.

@Mzack9999 Mzack9999 self-assigned this Aug 16, 2021
@Mzack9999 Mzack9999 linked a pull request Aug 16, 2021 that will close this issue
Improving case behavior with methods CLI option #369
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Aug 16, 2021
@ehsandeep ehsandeep linked a pull request Aug 17, 2021 that will close this issue
v1.1.2 Release preparation #370
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mzack9999 Mzack9999

Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
3 participants
@ehsandeep @Mzack9999 @puckk