Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change options.TechDetect variable type from string to boolean #1700

Closed
Mzack9999 opened this issue May 14, 2024 · 0 comments · Fixed by #1702
Closed

Change options.TechDetect variable type from string to boolean #1700

Mzack9999 opened this issue May 14, 2024 · 0 comments · Fixed by #1702
Assignees
@dogancanbakir
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Comments

@Mzack9999
Copy link
Member

Description

Evaluate if changing options.TechDetect from flagSet.DynamicVarP to boolean (flagSet.BoolVarP) makes sense. Within the code it's compared with literal values with true/false, so probably it can be changed directly to bool
@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label May 14, 2024
@dogancanbakir dogancanbakir self-assigned this May 14, 2024
@dogancanbakir dogancanbakir mentioned this issue May 15, 2024
Merged
@Mzack9999 Mzack9999 linked a pull request May 15, 2024 that will close this issue
change -tech-detect flag var type #1702
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dogancanbakir dogancanbakir

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change -tech-detect flag var type projectdiscovery/httpx
3 participants
@ehsandeep @Mzack9999 @dogancanbakir