From f8bfde1f0dbe48fc70c24ddba441cd0ee21c4d17 Mon Sep 17 00:00:00 2001 From: Tilo Stoppe Date: Tue, 7 Jan 2025 11:00:03 +0100 Subject: [PATCH] fix(form): css class naming, minor label-test improvements for mandatory asterisk --- packages/form/addon/components/cf-field/label.hbs | 2 +- packages/form/addon/components/cf-field/label.js | 2 +- .../form/tests/integration/components/cf-field/label-test.js | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/form/addon/components/cf-field/label.hbs b/packages/form/addon/components/cf-field/label.hbs index cd9c3a156..fc844af1f 100644 --- a/packages/form/addon/components/cf-field/label.hbs +++ b/packages/form/addon/components/cf-field/label.hbs @@ -11,7 +11,7 @@ {{else if (and (not @field.optional) this.useMandatoryAsterisk)}} * {{/if}} {{/unless}} diff --git a/packages/form/addon/components/cf-field/label.js b/packages/form/addon/components/cf-field/label.js index 87b6839d3..21476e776 100644 --- a/packages/form/addon/components/cf-field/label.js +++ b/packages/form/addon/components/cf-field/label.js @@ -15,6 +15,6 @@ export default class CfFieldLabelComponent extends Component { const { USE_MANDATORY_ASTERISK = false } = this.config["ember-caluma"] || {}; - return this.args?.useMandatoryAsterisk ?? USE_MANDATORY_ASTERISK; + return this.args.useMandatoryAsterisk ?? USE_MANDATORY_ASTERISK; } } diff --git a/packages/form/tests/integration/components/cf-field/label-test.js b/packages/form/tests/integration/components/cf-field/label-test.js index 3c0eedf4d..c71ec4968 100644 --- a/packages/form/tests/integration/components/cf-field/label-test.js +++ b/packages/form/tests/integration/components/cf-field/label-test.js @@ -59,12 +59,11 @@ module("Integration | Component | cf-field/label", function (hooks) { test("it marks mandatory fields as such if useMandatoryAsterisk is configured in attribute", async function (assert) { assert.expect(2); - this.set("useMandatoryAsterisk", true); await render( hbs``, );