diff --git a/Makefile b/Makefile index 2a91e164..a748ba21 100644 --- a/Makefile +++ b/Makefile @@ -53,7 +53,6 @@ comma := , prefix_linux = $(addprefix linux/,$(strip $1)) join_platforms = $(subst $(space),$(comma),$(call prefix_linux,$(strip $1))) - # list of arches *not* to build when doing *-all # until s390x works correctly EXCLUDEARCH ?= s390x @@ -240,7 +239,6 @@ else $(NOECHO) $(NOOP) endif - ## tag images of one arch tag-images: imagetag $(addprefix sub-single-tag-images-arch-,$(call escapefs,$(PUSH_IMAGES))) $(addprefix sub-single-tag-images-non-manifest-,$(call escapefs,$(PUSH_NONMANIFEST_IMAGES))) sub-single-tag-images-arch-%: @@ -254,14 +252,11 @@ else $(NOECHO) $(NOOP) endif - - ## tag images of all archs tag-images-all: imagetag $(addprefix sub-tag-images-,$(VALIDARCHES)) sub-tag-images-%: $(MAKE) tag-images ARCH=$* IMAGETAG=$(IMAGETAG) - ############################################################################### # Static checks ############################################################################### @@ -376,8 +371,8 @@ endif ## Verifies the release artifacts produces by `make release-build` are correct. release-verify: release-prereqs # Check the reported version is correct for each release artifact. - if ! docker run $(BUILD_IMAGE):$(VERSION) -v | grep '^$(VERSION)$$'; then echo "Reported version:" `docker run $(BUILD_IMAGE):$(VERSION) -v` "\nExpected version: $(VERSION)"; false; else echo "\nVersion check passed\n"; fi - if ! docker run quay.io/$(BUILD_IMAGE):$(VERSION) -v | grep '^$(VERSION)$$'; then echo "Reported version:" `docker run quay.io/$(BUILD_IMAGE):$(VERSION) -v` "\nExpected version: $(VERSION)"; false; else echo "\nVersion check passed\n"; fi + if ! docker run $(BUILD_IMAGE):$(VERSION)-$(ARCH) -v | grep '^$(VERSION)$$'; then echo "Reported version:" `docker run $(BUILD_IMAGE):$(VERSION)-$(ARCH) -v` "\nExpected version: $(VERSION)"; false; else echo "\nVersion check passed\n"; fi + if ! docker run quay.io/$(BUILD_IMAGE):$(VERSION)-$(ARCH) -v | grep '^$(VERSION)$$'; then echo "Reported version:" `docker run quay.io/$(BUILD_IMAGE):$(VERSION)-$(ARCH) -v` "\nExpected version: $(VERSION)"; false; else echo "\nVersion check passed\n"; fi ## Generates release notes based on commits in this version. release-notes: release-prereqs @@ -391,7 +386,7 @@ release-publish: release-prereqs git push origin $(VERSION) # Push images. - $(MAKE) push-all IMAGETAG=$(VERSION) + $(MAKE) push-all push-manifests push-non-manifests IMAGETAG=$(VERSION) @echo "Finalize the GitHub release based on the pushed tag." @echo "" @@ -410,7 +405,7 @@ release-publish-latest: release-prereqs if ! docker run $(BUILD_IMAGE):latest -v | grep '^$(VERSION)$$'; then echo "Reported version:" `docker run $(BUILD_IMAGE):latest -v` "\nExpected version: $(VERSION)"; false; else echo "\nVersion check passed\n"; fi if ! docker run quay.io/$(BUILD_IMAGE):latest -v | grep '^$(VERSION)$$'; then echo "Reported version:" `docker run quay.io/$(BUILD_IMAGE):latest -v` "\nExpected version: $(VERSION)"; false; else echo "\nVersion check passed\n"; fi - $(MAKE) push-all IMAGETAG=latest + $(MAKE) push-all push-manifests push-non-manifests IMAGETAG=latest # release-prereqs checks that the environment is configured properly to create a release. release-prereqs: @@ -418,7 +413,6 @@ ifndef VERSION $(error VERSION is undefined - run using make release VERSION=vX.Y.Z) endif - ############################################################################### # Developer helper scripts (not used by build or test) ###############################################################################