Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup zap/repo/src-electron/generator/matter/app/zap-templates/templates #682

Closed
brdandu opened this issue Aug 19, 2022 · 2 comments · Fixed by #989
Closed

Cleanup zap/repo/src-electron/generator/matter/app/zap-templates/templates #682

brdandu opened this issue Aug 19, 2022 · 2 comments · Fixed by #989
Assignees
@brdandu
Labels
high priority Tag that shows this as higher priority as other issues. MatterZapCleanup

Comments

@brdandu
Copy link
Collaborator

brdandu commented Aug 19, 2022

The goal is to eventually cleanup the matter specific zap code to not have any state for eg in ClustersHelper.js
During this cleanup we want to do the following:

  • Go through the matter directory in this issue. See if these helpers can have code pushed to the backend sql queries.
  • See if the helpers can use any of the existing helper logic and can remove code redundancy
  • Add unit tests for each of the helpers listed
  • Make sure to have a CHIP/Zigbee repo branch that points to your changes and passes the CI on both places
  • Also if you can fix anything new apart from what is listed then fix those issues as well.
@brdandu brdandu added high priority Tag that shows this as higher priority as other issues. MatterZapCleanup labels Aug 19, 2022
@brdandu brdandu self-assigned this Oct 5, 2022
@brdandu brdandu linked a pull request Oct 31, 2022 that will close this issue
Cleaning up Matter zap code and adding functionality to existing zap helpers and creating new ones to remove state in Matter's zap code: #779
Closed
@brdandu
Copy link
Collaborator Author

brdandu commented Oct 31, 2022 •
edited
Loading

Chip Repo PR: project-chip/connectedhomeip#23410 : The changes here were split into multiple PRs and resolved in #898 and #971

@brdandu brdandu linked a pull request Apr 4, 2023 that will close this issue
Deprecating the matter stateful helpers #989
Merged
@brdandu
Copy link
Collaborator Author

brdandu commented Apr 4, 2023 •
edited
Loading

Miscellaneous Stateful helper removal chip repo PR: project-chip/connectedhomeip#25978
and project-chip/connectedhomeip#26016

@brdandu brdandu reopened this Apr 5, 2023
@brdandu brdandu closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brdandu brdandu

Labels
high priority Tag that shows this as higher priority as other issues. MatterZapCleanup
Projects
None yet
Milestone
No milestone
1 participant
@brdandu