From fca3b618d73fc1a2a4feb93e545ea693b423f0e1 Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Tue, 15 Mar 2022 09:42:04 -0400 Subject: [PATCH 1/5] Add ota provider/requestor to build_examples.py --- scripts/build/build/targets.py | 2 + scripts/build/builders/host.py | 12 ++++ scripts/build/testdata/build_linux_on_x64.txt | 56 +++++++++++++++++++ 3 files changed, 70 insertions(+) diff --git a/scripts/build/build/targets.py b/scripts/build/build/targets.py index d0c3763e06070d..106dc1de077079 100644 --- a/scripts/build/build/targets.py +++ b/scripts/build/build/targets.py @@ -154,6 +154,8 @@ def HostTargets(): app_targets.append(target.Extend('minmdns', app=HostApp.MIN_MDNS)) app_targets.append(target.Extend('door-lock', app=HostApp.LOCK)) app_targets.append(target.Extend('shell', app=HostApp.SHELL)) + app_targets.append(target.Extend('ota-provider', app=HostApp.OTA_PROVIDER)) + app_targets.append(target.Extend('ota-requestor', app=HostApp.OTA_REQUESTOR)) # Possible build variants. Note that number of potential # builds is exponential here diff --git a/scripts/build/builders/host.py b/scripts/build/builders/host.py index 67fa96f008ac0a..e4b6c8dc4bc1f8 100644 --- a/scripts/build/builders/host.py +++ b/scripts/build/builders/host.py @@ -32,6 +32,8 @@ class HostApp(Enum): TESTS = auto() SHELL = auto() CERT_TOOL = auto() + OTA_PROVIDER = auto() + OTA_REQUESTOR = auto() def ExamplePath(self): if self == HostApp.ALL_CLUSTERS: @@ -56,6 +58,10 @@ def ExamplePath(self): return 'shell/standalone' elif self == HostApp.CERT_TOOL: return '..' + elif self == HostApp.OTA_PROVIDER: + return 'ota-provider-app/linux' + elif self == HostApp.OTA_REQUESTOR: + return 'ota-requestor-app/linux' else: raise Exception('Unknown app type: %r' % self) @@ -95,6 +101,12 @@ def OutputNames(self): elif self == HostApp.CERT_TOOL: yield 'chip-cert' yield 'chip-cert.map' + elif self == HostApp.OTA_PROVIDER: + yield 'ota-requestor-app' + yield 'ota-requestor-app.map' + elif self == HostApp.OTA_REQUESTOR: + yield 'ota-provider-app' + yield 'ota-provider-app.map' else: raise Exception('Unknown app type: %r' % self) diff --git a/scripts/build/testdata/build_linux_on_x64.txt b/scripts/build/testdata/build_linux_on_x64.txt index 62a44b15655273..2a759bcc625827 100644 --- a/scripts/build/testdata/build_linux_on_x64.txt +++ b/scripts/build/testdata/build_linux_on_x64.txt @@ -41,6 +41,26 @@ bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/minimal-mdns '"'"'--args=chip_inet_config_enable_ipv4=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-minmdns-ipv6only' +# Generating linux-arm64-ota-provider +bash -c ' +PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider' + +# Generating linux-arm64-ota-provider-ipv6only +bash -c ' +PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider-ipv6only' + +# Generating linux-arm64-ota-requestor +bash -c ' +PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor' + +# Generating linux-arm64-ota-requestor-ipv6only +bash -c ' +PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor-ipv6only' + # Generating linux-arm64-shell bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ @@ -94,6 +114,18 @@ gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/exa # Generating linux-x64-minmdns-ipv6only gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/minimal-mdns --args=chip_inet_config_enable_ipv4=false {out}/linux-x64-minmdns-ipv6only +# Generating linux-x64-ota-provider +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux {out}/linux-x64-ota-provider + +# Generating linux-x64-ota-provider-ipv6only +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux --args=chip_inet_config_enable_ipv4=false {out}/linux-x64-ota-provider-ipv6only + +# Generating linux-x64-ota-requestor +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux {out}/linux-x64-ota-requestor + +# Generating linux-x64-ota-requestor-ipv6only +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux --args=chip_inet_config_enable_ipv4=false {out}/linux-x64-ota-requestor-ipv6only + # Generating linux-x64-rpc-console gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/common/pigweed/rpc_console {out}/linux-x64-rpc-console @@ -142,6 +174,18 @@ ninja -C {out}/linux-arm64-minmdns # Building linux-arm64-minmdns-ipv6only ninja -C {out}/linux-arm64-minmdns-ipv6only +# Building linux-arm64-ota-provider +ninja -C {out}/linux-arm64-ota-provider + +# Building linux-arm64-ota-provider-ipv6only +ninja -C {out}/linux-arm64-ota-provider-ipv6only + +# Building linux-arm64-ota-requestor +ninja -C {out}/linux-arm64-ota-requestor + +# Building linux-arm64-ota-requestor-ipv6only +ninja -C {out}/linux-arm64-ota-requestor-ipv6only + # Building linux-arm64-shell ninja -C {out}/linux-arm64-shell @@ -187,6 +231,18 @@ ninja -C {out}/linux-x64-minmdns # Building linux-x64-minmdns-ipv6only ninja -C {out}/linux-x64-minmdns-ipv6only +# Building linux-x64-ota-provider +ninja -C {out}/linux-x64-ota-provider + +# Building linux-x64-ota-provider-ipv6only +ninja -C {out}/linux-x64-ota-provider-ipv6only + +# Building linux-x64-ota-requestor +ninja -C {out}/linux-x64-ota-requestor + +# Building linux-x64-ota-requestor-ipv6only +ninja -C {out}/linux-x64-ota-requestor-ipv6only + # Building linux-x64-rpc-console ninja -C {out}/linux-x64-rpc-console From f6c98739c5cbd7015e5f5829946e34131be28c40 Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Tue, 15 Mar 2022 09:47:22 -0400 Subject: [PATCH 2/5] Build provider/requestor without BLE to start --- scripts/build/build/targets.py | 4 +- scripts/build/builders/host.py | 3 +- scripts/build/testdata/build_linux_on_x64.txt | 64 +++++++++---------- 3 files changed, 35 insertions(+), 36 deletions(-) diff --git a/scripts/build/build/targets.py b/scripts/build/build/targets.py index 106dc1de077079..d9c25af5860aad 100644 --- a/scripts/build/build/targets.py +++ b/scripts/build/build/targets.py @@ -154,8 +154,8 @@ def HostTargets(): app_targets.append(target.Extend('minmdns', app=HostApp.MIN_MDNS)) app_targets.append(target.Extend('door-lock', app=HostApp.LOCK)) app_targets.append(target.Extend('shell', app=HostApp.SHELL)) - app_targets.append(target.Extend('ota-provider', app=HostApp.OTA_PROVIDER)) - app_targets.append(target.Extend('ota-requestor', app=HostApp.OTA_REQUESTOR)) + app_targets.append(target.Extend('ota-provider-noble', app=HostApp.OTA_PROVIDER, enable_ble=False)) + app_targets.append(target.Extend('ota-requestor-noble', app=HostApp.OTA_REQUESTOR, enable_ble=False)) # Possible build variants. Note that number of potential # builds is exponential here diff --git a/scripts/build/builders/host.py b/scripts/build/builders/host.py index e4b6c8dc4bc1f8..d13c889ff453eb 100644 --- a/scripts/build/builders/host.py +++ b/scripts/build/builders/host.py @@ -156,8 +156,7 @@ class HostBuilder(GnBuilder): def __init__(self, root, runner, app: HostApp, board=HostBoard.NATIVE, enable_ipv4=True, enable_ble=True, use_tsan=False, use_asan=False, separate_event_loop=True, test_group=False, use_libfuzzer=False, use_clang=False, - use_platform_mdns=False - ): + use_platform_mdns=False): super(HostBuilder, self).__init__( root=os.path.join(root, 'examples', app.ExamplePath()), runner=runner) diff --git a/scripts/build/testdata/build_linux_on_x64.txt b/scripts/build/testdata/build_linux_on_x64.txt index 2a759bcc625827..29f7249c4111a1 100644 --- a/scripts/build/testdata/build_linux_on_x64.txt +++ b/scripts/build/testdata/build_linux_on_x64.txt @@ -41,25 +41,25 @@ bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/minimal-mdns '"'"'--args=chip_inet_config_enable_ipv4=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-minmdns-ipv6only' -# Generating linux-arm64-ota-provider +# Generating linux-arm64-ota-provider-noble bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider-noble' -# Generating linux-arm64-ota-provider-ipv6only +# Generating linux-arm64-ota-provider-noble-ipv6only bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider-ipv6only' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider-noble-ipv6only' -# Generating linux-arm64-ota-requestor +# Generating linux-arm64-ota-requestor-noble bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor-noble' -# Generating linux-arm64-ota-requestor-ipv6only +# Generating linux-arm64-ota-requestor-noble-ipv6only bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor-ipv6only' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor-noble-ipv6only' # Generating linux-arm64-shell bash -c ' @@ -114,17 +114,17 @@ gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/exa # Generating linux-x64-minmdns-ipv6only gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/minimal-mdns --args=chip_inet_config_enable_ipv4=false {out}/linux-x64-minmdns-ipv6only -# Generating linux-x64-ota-provider -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux {out}/linux-x64-ota-provider +# Generating linux-x64-ota-provider-noble +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux --args=chip_config_network_layer_ble=false {out}/linux-x64-ota-provider-noble -# Generating linux-x64-ota-provider-ipv6only -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux --args=chip_inet_config_enable_ipv4=false {out}/linux-x64-ota-provider-ipv6only +# Generating linux-x64-ota-provider-noble-ipv6only +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false' {out}/linux-x64-ota-provider-noble-ipv6only -# Generating linux-x64-ota-requestor -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux {out}/linux-x64-ota-requestor +# Generating linux-x64-ota-requestor-noble +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux --args=chip_config_network_layer_ble=false {out}/linux-x64-ota-requestor-noble -# Generating linux-x64-ota-requestor-ipv6only -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux --args=chip_inet_config_enable_ipv4=false {out}/linux-x64-ota-requestor-ipv6only +# Generating linux-x64-ota-requestor-noble-ipv6only +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false' {out}/linux-x64-ota-requestor-noble-ipv6only # Generating linux-x64-rpc-console gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/common/pigweed/rpc_console {out}/linux-x64-rpc-console @@ -174,17 +174,17 @@ ninja -C {out}/linux-arm64-minmdns # Building linux-arm64-minmdns-ipv6only ninja -C {out}/linux-arm64-minmdns-ipv6only -# Building linux-arm64-ota-provider -ninja -C {out}/linux-arm64-ota-provider +# Building linux-arm64-ota-provider-noble +ninja -C {out}/linux-arm64-ota-provider-noble -# Building linux-arm64-ota-provider-ipv6only -ninja -C {out}/linux-arm64-ota-provider-ipv6only +# Building linux-arm64-ota-provider-noble-ipv6only +ninja -C {out}/linux-arm64-ota-provider-noble-ipv6only -# Building linux-arm64-ota-requestor -ninja -C {out}/linux-arm64-ota-requestor +# Building linux-arm64-ota-requestor-noble +ninja -C {out}/linux-arm64-ota-requestor-noble -# Building linux-arm64-ota-requestor-ipv6only -ninja -C {out}/linux-arm64-ota-requestor-ipv6only +# Building linux-arm64-ota-requestor-noble-ipv6only +ninja -C {out}/linux-arm64-ota-requestor-noble-ipv6only # Building linux-arm64-shell ninja -C {out}/linux-arm64-shell @@ -231,17 +231,17 @@ ninja -C {out}/linux-x64-minmdns # Building linux-x64-minmdns-ipv6only ninja -C {out}/linux-x64-minmdns-ipv6only -# Building linux-x64-ota-provider -ninja -C {out}/linux-x64-ota-provider +# Building linux-x64-ota-provider-noble +ninja -C {out}/linux-x64-ota-provider-noble -# Building linux-x64-ota-provider-ipv6only -ninja -C {out}/linux-x64-ota-provider-ipv6only +# Building linux-x64-ota-provider-noble-ipv6only +ninja -C {out}/linux-x64-ota-provider-noble-ipv6only -# Building linux-x64-ota-requestor -ninja -C {out}/linux-x64-ota-requestor +# Building linux-x64-ota-requestor-noble +ninja -C {out}/linux-x64-ota-requestor-noble -# Building linux-x64-ota-requestor-ipv6only -ninja -C {out}/linux-x64-ota-requestor-ipv6only +# Building linux-x64-ota-requestor-noble-ipv6only +ninja -C {out}/linux-x64-ota-requestor-noble-ipv6only # Building linux-x64-rpc-console ninja -C {out}/linux-x64-rpc-console From 4da5c1cefca84637fa60de356b9d49cbf34c902e Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Tue, 15 Mar 2022 09:49:41 -0400 Subject: [PATCH 3/5] Noble is a standard variant - revert the default --- scripts/build/build/targets.py | 4 +- scripts/build/testdata/build_linux_on_x64.txt | 64 +++++++++---------- 2 files changed, 34 insertions(+), 34 deletions(-) diff --git a/scripts/build/build/targets.py b/scripts/build/build/targets.py index d9c25af5860aad..4d26363a3743cc 100644 --- a/scripts/build/build/targets.py +++ b/scripts/build/build/targets.py @@ -154,8 +154,8 @@ def HostTargets(): app_targets.append(target.Extend('minmdns', app=HostApp.MIN_MDNS)) app_targets.append(target.Extend('door-lock', app=HostApp.LOCK)) app_targets.append(target.Extend('shell', app=HostApp.SHELL)) - app_targets.append(target.Extend('ota-provider-noble', app=HostApp.OTA_PROVIDER, enable_ble=False)) - app_targets.append(target.Extend('ota-requestor-noble', app=HostApp.OTA_REQUESTOR, enable_ble=False)) + app_targets.append(target.Extend('ota-provider', app=HostApp.OTA_PROVIDER, enable_ble=False)) + app_targets.append(target.Extend('ota-requestor', app=HostApp.OTA_REQUESTOR, enable_ble=False)) # Possible build variants. Note that number of potential # builds is exponential here diff --git a/scripts/build/testdata/build_linux_on_x64.txt b/scripts/build/testdata/build_linux_on_x64.txt index 29f7249c4111a1..44f1f6addfd6ea 100644 --- a/scripts/build/testdata/build_linux_on_x64.txt +++ b/scripts/build/testdata/build_linux_on_x64.txt @@ -41,25 +41,25 @@ bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/minimal-mdns '"'"'--args=chip_inet_config_enable_ipv4=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-minmdns-ipv6only' -# Generating linux-arm64-ota-provider-noble +# Generating linux-arm64-ota-provider bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider-noble' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider' -# Generating linux-arm64-ota-provider-noble-ipv6only +# Generating linux-arm64-ota-provider-ipv6only bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider-noble-ipv6only' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-provider-ipv6only' -# Generating linux-arm64-ota-requestor-noble +# Generating linux-arm64-ota-requestor bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor-noble' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor' -# Generating linux-arm64-ota-requestor-noble-ipv6only +# Generating linux-arm64-ota-requestor-ipv6only bash -c ' PKG_CONFIG_PATH="SYSROOT_AARCH64/lib/aarch64-linux-gnu/pkgconfig" \ - gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor-noble-ipv6only' + gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '"'"'--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false target_cpu="arm64" is_clang=true chip_crypto="mbedtls" sysroot="SYSROOT_AARCH64"'"'"' {out}/linux-arm64-ota-requestor-ipv6only' # Generating linux-arm64-shell bash -c ' @@ -114,17 +114,17 @@ gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/exa # Generating linux-x64-minmdns-ipv6only gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/minimal-mdns --args=chip_inet_config_enable_ipv4=false {out}/linux-x64-minmdns-ipv6only -# Generating linux-x64-ota-provider-noble -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux --args=chip_config_network_layer_ble=false {out}/linux-x64-ota-provider-noble +# Generating linux-x64-ota-provider +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux --args=chip_config_network_layer_ble=false {out}/linux-x64-ota-provider -# Generating linux-x64-ota-provider-noble-ipv6only -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false' {out}/linux-x64-ota-provider-noble-ipv6only +# Generating linux-x64-ota-provider-ipv6only +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-provider-app/linux '--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false' {out}/linux-x64-ota-provider-ipv6only -# Generating linux-x64-ota-requestor-noble -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux --args=chip_config_network_layer_ble=false {out}/linux-x64-ota-requestor-noble +# Generating linux-x64-ota-requestor +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux --args=chip_config_network_layer_ble=false {out}/linux-x64-ota-requestor -# Generating linux-x64-ota-requestor-noble-ipv6only -gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false' {out}/linux-x64-ota-requestor-noble-ipv6only +# Generating linux-x64-ota-requestor-ipv6only +gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/ota-requestor-app/linux '--args=chip_inet_config_enable_ipv4=false chip_config_network_layer_ble=false' {out}/linux-x64-ota-requestor-ipv6only # Generating linux-x64-rpc-console gn gen --check --fail-on-unused-args --export-compile-commands --root={root}/examples/common/pigweed/rpc_console {out}/linux-x64-rpc-console @@ -174,17 +174,17 @@ ninja -C {out}/linux-arm64-minmdns # Building linux-arm64-minmdns-ipv6only ninja -C {out}/linux-arm64-minmdns-ipv6only -# Building linux-arm64-ota-provider-noble -ninja -C {out}/linux-arm64-ota-provider-noble +# Building linux-arm64-ota-provider +ninja -C {out}/linux-arm64-ota-provider -# Building linux-arm64-ota-provider-noble-ipv6only -ninja -C {out}/linux-arm64-ota-provider-noble-ipv6only +# Building linux-arm64-ota-provider-ipv6only +ninja -C {out}/linux-arm64-ota-provider-ipv6only -# Building linux-arm64-ota-requestor-noble -ninja -C {out}/linux-arm64-ota-requestor-noble +# Building linux-arm64-ota-requestor +ninja -C {out}/linux-arm64-ota-requestor -# Building linux-arm64-ota-requestor-noble-ipv6only -ninja -C {out}/linux-arm64-ota-requestor-noble-ipv6only +# Building linux-arm64-ota-requestor-ipv6only +ninja -C {out}/linux-arm64-ota-requestor-ipv6only # Building linux-arm64-shell ninja -C {out}/linux-arm64-shell @@ -231,17 +231,17 @@ ninja -C {out}/linux-x64-minmdns # Building linux-x64-minmdns-ipv6only ninja -C {out}/linux-x64-minmdns-ipv6only -# Building linux-x64-ota-provider-noble -ninja -C {out}/linux-x64-ota-provider-noble +# Building linux-x64-ota-provider +ninja -C {out}/linux-x64-ota-provider -# Building linux-x64-ota-provider-noble-ipv6only -ninja -C {out}/linux-x64-ota-provider-noble-ipv6only +# Building linux-x64-ota-provider-ipv6only +ninja -C {out}/linux-x64-ota-provider-ipv6only -# Building linux-x64-ota-requestor-noble -ninja -C {out}/linux-x64-ota-requestor-noble +# Building linux-x64-ota-requestor +ninja -C {out}/linux-x64-ota-requestor -# Building linux-x64-ota-requestor-noble-ipv6only -ninja -C {out}/linux-x64-ota-requestor-noble-ipv6only +# Building linux-x64-ota-requestor-ipv6only +ninja -C {out}/linux-x64-ota-requestor-ipv6only # Building linux-x64-rpc-console ninja -C {out}/linux-x64-rpc-console From 7ebb4b8fd9894433bfe87d8cf0cba3cafd41822e Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Tue, 15 Mar 2022 09:51:59 -0400 Subject: [PATCH 4/5] Fix application name for build package generation --- scripts/build/builders/host.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/build/builders/host.py b/scripts/build/builders/host.py index d13c889ff453eb..0e3561b9fda821 100644 --- a/scripts/build/builders/host.py +++ b/scripts/build/builders/host.py @@ -102,11 +102,11 @@ def OutputNames(self): yield 'chip-cert' yield 'chip-cert.map' elif self == HostApp.OTA_PROVIDER: - yield 'ota-requestor-app' - yield 'ota-requestor-app.map' + yield 'chip-ota-requestor-app' + yield 'chip-ota-requestor-app.map' elif self == HostApp.OTA_REQUESTOR: - yield 'ota-provider-app' - yield 'ota-provider-app.map' + yield 'chip-ota-provider-app' + yield 'chip-ota-provider-app.map' else: raise Exception('Unknown app type: %r' % self) From 69735cbc09bc8761a0a65a094e9aed7b03960fc1 Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Tue, 15 Mar 2022 10:28:56 -0400 Subject: [PATCH 5/5] Restyle --- scripts/build/build/targets.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/build/build/targets.py b/scripts/build/build/targets.py index 4d26363a3743cc..d35d1905103e02 100644 --- a/scripts/build/build/targets.py +++ b/scripts/build/build/targets.py @@ -154,8 +154,10 @@ def HostTargets(): app_targets.append(target.Extend('minmdns', app=HostApp.MIN_MDNS)) app_targets.append(target.Extend('door-lock', app=HostApp.LOCK)) app_targets.append(target.Extend('shell', app=HostApp.SHELL)) - app_targets.append(target.Extend('ota-provider', app=HostApp.OTA_PROVIDER, enable_ble=False)) - app_targets.append(target.Extend('ota-requestor', app=HostApp.OTA_REQUESTOR, enable_ble=False)) + app_targets.append(target.Extend( + 'ota-provider', app=HostApp.OTA_PROVIDER, enable_ble=False)) + app_targets.append(target.Extend( + 'ota-requestor', app=HostApp.OTA_REQUESTOR, enable_ble=False)) # Possible build variants. Note that number of potential # builds is exponential here