Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple peer address into transport, such that pairing session do not need to h... #9062

Closed
todo bot opened this issue Aug 16, 2021 · 1 comment · Fixed by #9269
Closed

decouple peer address into transport, such that pairing session do not need to h... #9062

todo bot opened this issue Aug 16, 2021 · 1 comment · Fixed by #9269
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Aug 16, 2021

// TODO: decouple peer address into transport, such that pairing session do not need to handle peer address
const Transport::PeerAddress & GetPeerAddress() const { return mPeerAddress; }
Transport::PeerAddress & GetPeerAddress() { return mPeerAddress; }
void SetPeerAddress(const Transport::PeerAddress & address) { mPeerAddress = address; }
// TODO: remove Clear, we should create a new instance instead reset the old instance.
void Clear()
{
mPeerNodeId = kUndefinedNodeId;
mPeerAddress = Transport::PeerAddress::Uninitialized();
mPeerKeyId.ClearValue();


This issue was generated by todo based on a TODO comment in d0364de when #8107 was merged. cc @kghost.
@todo todo bot added the todo label Aug 16, 2021
@todo todo bot assigned kghost Aug 16, 2021
@kghost kghost linked a pull request Sep 4, 2021 that will close this issue
@kghost
Copy link
Contributor

kghost commented Sep 4, 2021

This issue will be solved by #9269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant