Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When matter_enable_java_compilation is true, it assumes the build is on linux which leads to an assert on darwin platform #34586

Closed
mkardous-silabs opened this issue Jul 29, 2024 · 1 comment · Fixed by #34608
Assignees
Labels
bug Something isn't working darwin gn java Issues in java-matter-controller

Comments

@mkardous-silabs
Copy link
Contributor

Reproduction steps

  1. Set the JAVA_PATH environment variable
  2. On MacOS, run the bootstrap script
  3. Bootstrap will assert because the GN files incorrectly assume the build is on linux.

Bug prevalence

Systematically

GitHub hash of the SDK that was being used

decd9e9

Platform

darwin

Platform Version(s)

No response

Anything else?

Failure Logs

ERROR at //src/platform/Linux/BUILD.gn:23:1: Assertion failed.
assert(chip_device_platform == "linux")
^-----
See //src/messaging/tests/java/BUILD.gn:39:15: which caused the file to be included.
    deps += [ "${chip_root}/src/platform/Linux" ]
              ^--------------------------------
['gn', 'gen', '/Users/makardou/code/connectedhomeip/.environment/gn_out', '--args=chip_crypto="boringssl" dir_pigweed="/Users/makardou/code/connectedhomeip/third_party/pigweed/repo"']

Issue is in build/chip/java/config.gni due to this conditional :
if (java_path != "" && (current_os == "linux" || current_os == "mac")) {

@joonhaengHeo
Copy link
Contributor

@mkardous-silabs
Please check my PR.
I modified it in the same way as the code below.

if (current_os == "mac") {

@joonhaengHeo joonhaengHeo self-assigned this Jul 29, 2024
@mergify mergify bot closed this as completed in #34608 Jul 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working darwin gn java Issues in java-matter-controller
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants