-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/CD] detect and prevent unintended third_party repo updates #30746
Comments
Either we need a script to detect changes or maybe some rule based on paths changed ... if anything in "/third_party/" is modified we need to run some validation. https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/kotlin-style.yaml#L6 - is an example of a workflow that runs for specific path changes only. So we need some logic like: |
I think what we could try for starters is create a yaml that:
I can put together an initial script for these requirements this week and have you look over it, Vatsal. |
To implement the |
Due to codegen, developers often do
git commit -a
to add all changed files, however this also can easily unintentionally change submodues if a they are not synchronized.Then we have to undo that change (when/if we notice) like in
#30451
#28164
and others. These were the ones that made through, code reviews catch others some of the time, however it is tedious and humans make mistakes.
We should have something that flags PRs that intentionally change submodules and flak (likely failing CI) if unintentional submodules change. Something like a
Changing submodules: lwip, gecko_sdk
in a comment (I like this because specific) or a label (likechanging-submodules-on-purpose
) should probably be a requirement to have PRs go in that update submodules.We also have to make sure dependabot changes go through (configured through https://github.com/project-chip/connectedhomeip/blob/master/.github/dependabot.yml, they create PRs like https://github.com/project-chip/connectedhomeip/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+is%3Aclosed)
The text was updated successfully, but these errors were encountered: