Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASESession.cpp and PASESession.cpp should be using named tag #30476

Open
tehampson opened this issue Nov 14, 2023 · 0 comments · May be fixed by #37383
Open

CASESession.cpp and PASESession.cpp should be using named tag #30476

tehampson opened this issue Nov 14, 2023 · 0 comments · May be fixed by #37383
Assignees

Comments

@tehampson
Copy link
Contributor

This came up during PR review here.

All TLV tags used in this file are using numbers instead of some sort of named tag making it more readable
Example:

 ReturnErrorOnFailure(EncodeSessionParameters(TLV::ContextTag(5), mLocalMRPConfig, tlvWriterMsg2));

Reason for not cleaning up in PR issue brought up:

  • This has always been there and is an easy cleanup on it own.
  • PR is already large and requires approvals. No sense adding burden to reviewers to clean up something not introduced in this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants