Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In PairingSession::EncodeSessionParameters figure out what MRP values we should sent when providedMrpConfig.HasValue() == false #30456

Closed
tehampson opened this issue Nov 13, 2023 · 1 comment · Fixed by #32324
Closed

In PairingSession::EncodeSessionParameters figure out what MRP values we should sent when providedMrpConfig.HasValue() == false #30456

tehampson opened this issue Nov 13, 2023 · 1 comment · Fixed by #32324
Assignees
@tehampson

Comments

@tehampson
Copy link
Contributor

Based on the spec For backwards compatibility, if any tag after tag 2 (SESSION_ACTIVE_INTERVAL) is present, then the SESSION_ACTIVE_INTERVAL SHALL also be present.

The spec really doesn't define what should happen if we don't have a local config. The other side would assume GetDefaultMRPConfig(). But it is not entirely clear if these are the same values on both side
@tehampson tehampson self-assigned this Nov 13, 2023
This was referenced Nov 13, 2023
Open
Merged
@bzbarsky-apple
Copy link
Contributor

The real question is this: under what conditions would we not have a local config?

@tehampson tehampson changed the title In PairingSession::EncodeSessionParameters figure out what MRP values we should send when providedMrpConfig.HasValue() == false In PairingSession::EncodeSessionParameters figure out what MRP values we should sent when providedMrpConfig.HasValue() == false Nov 16, 2023
@tehampson tehampson mentioned this issue Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tehampson tehampson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have PairingSession::EncodeSessionParameters require local MRP values tehampson/connectedhomeip
2 participants
@tehampson @bzbarsky-apple