Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scenes] Removing mNameLenght form SceneData in SceneTableImpl #30401

Closed
lpbeliveau-silabs opened this issue Nov 9, 2023 · 4 comments
Closed

Comments

@lpbeliveau-silabs
Copy link
Contributor

We need to remove mNameLength and ensure trailing null character removal.

Also, if https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/8022 is accepted, we can move to determine end of string with null terminators.

@lpbeliveau-silabs lpbeliveau-silabs converted this from a draft issue Nov 9, 2023
@lpbeliveau-silabs
Copy link
Contributor Author

See #30393 (comment) (and the remainder of the PR)

@bzbarsky-apple
Copy link
Contributor

The issue is not "trailing null character" so much as "you should be returning the strings you actually have, not something that includes extra garbage", no?

And no, you cannot move to determining end of string "with null terminators" for a data model string (i.e. CharSpan) someone hands you.

@andy31415
Copy link
Contributor

Technically including a null inside a string is allowed by the spec (you can have inside null, just no null at the end ... fun... I complained in the spec about this).

@lpbeliveau-silabs
Copy link
Contributor Author

Given the comments above, I am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants