-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Removing mNameLenght form SceneData in SceneTableImpl #30401
Comments
See #30393 (comment) (and the remainder of the PR) |
The issue is not "trailing null character" so much as "you should be returning the strings you actually have, not something that includes extra garbage", no? And no, you cannot move to determining end of string "with null terminators" for a data model string (i.e. CharSpan) someone hands you. |
Technically including a null inside a string is allowed by the spec (you can have inside null, just no null at the end ... fun... I complained in the spec about this). |
Given the comments above, I am closing the issue. |
We need to remove mNameLength and ensure trailing null character removal.
Also, if https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/8022 is accepted, we can move to determine end of string with null terminators.
The text was updated successfully, but these errors were encountered: