Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICD] Darwin implementation for the ICD Storage #29395

Open
yunhanw-google opened this issue Sep 21, 2023 · 4 comments
Open

[ICD] Darwin implementation for the ICD Storage #29395

yunhanw-google opened this issue Sep 21, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@yunhanw-google
Copy link
Contributor

yunhanw-google commented Sep 21, 2023

#29783 this PR does not provide ICDStorage per identify, per @bzbarsky-apple , darwin needs to implemented the dedicated per-identity storage for ICD.

@bzbarsky-apple
Copy link
Contributor

This should get piped through the existing machinery for these things, ideally.

@yunhanw-google
Copy link
Contributor Author

yes, agree

@yunhanw-google yunhanw-google changed the title [ICD] Darwin change for the ICD Auto-Subscribe callback [ICD] Darwin implementation for the ICD Storage Nov 30, 2023
@github-actions github-actions bot added darwin and removed darwin icd Intermittently Connected Devices labels Nov 30, 2023
@yunhanw-google
Copy link
Contributor Author

just update the ticket description, thanks

@bzbarsky-apple
Copy link
Contributor

It's really not clear so far based on the API definitions in the core which parts this implementation will have to do. This needs to wait until either the core part calling into the API is done or until the API has better documentation. Ideally the latter. @yunhanw-google @tcarmelveilleux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants