Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2] Remove the use of set in the Mode Base server code #28125

Closed
hicklin opened this issue Jul 20, 2023 · 0 comments · Fixed by #28163
Closed

[1.2] Remove the use of set in the Mode Base server code #28125

hicklin opened this issue Jul 20, 2023 · 0 comments · Fixed by #28163
Assignees
@hicklin
Labels
bug Something isn't working memory needs triage v1.2

Comments

@hicklin
Copy link
Contributor

hicklin commented Jul 20, 2023 •
edited
Loading

Reproduction steps

n/a

Bug prevalence

not a bug

GitHub hash of the SDK that was being used

3d63a73

Platform

other

Platform Version(s)

1.2

Type

Common Cluster Logic

Anything else?

The use of std::set is not compatible with embedded platforms. This needs to be replaced with an embedded friendly implementation. Consider the SDKs doubly linked list implementation, IntrusiveList`.

  • Replace the use of std::set with IntrusiveList.
  • Remove the exeption to use std::set from scripts/tools/check_includes_config.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hicklin hicklin

Labels
bug Something isn't working memory needs triage v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced the use of std::set with IntrusiveList in ModeBase. dysonltd/connectedhomeip
2 participants
@hicklin @bzbarsky-apple