You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Matter SDK has the feature, when the Commissioning window closes after some time of inactivity (15 minutes).
In this case the void OnCommissioningWindowClosed() called. But this function is also called if the Commissioning process closed the BLE session.
There is no mechanism to determine, on which reason the Commissioning window was closed.
In this pull request we can see that the call OnCommissioningWindowClosed() is adding misunderstanding at which situation was it called and forces us to make a special handling of the reason, why the window was closed. This delegate doesn't have any arguments, so we need to determine, was the session opened previously or not.
My proposal, that we need to add the argument to the delegates and forward the reason of calling this delegate.
Or we need to create a new delegate to handle the specific cases of closing the commissioning window.
Please read the conversation in the pull request to get familiar with the issue.
Feature description
Matter SDK has the feature, when the Commissioning window closes after some time of inactivity (15 minutes).
In this case the void OnCommissioningWindowClosed() called. But this function is also called if the Commissioning process closed the BLE session.
There is no mechanism to determine, on which reason the Commissioning window was closed.
In this pull request we can see that the call OnCommissioningWindowClosed() is adding misunderstanding at which situation was it called and forces us to make a special handling of the reason, why the window was closed. This delegate doesn't have any arguments, so we need to determine, was the session opened previously or not.
My proposal, that we need to add the argument to the delegates and forward the reason of calling this delegate.
Or we need to create a new delegate to handle the specific cases of closing the commissioning window.
Please read the conversation in the pull request to get familiar with the issue.
#26786
Platform
all
Platform Version(s)
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: