Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] New delegate for OnCommissioningWindowClosed after commissioning timeout expired #27002

Open
mishadesh opened this issue Jun 1, 2023 · 1 comment

Comments

@mishadesh
Copy link
Contributor

Feature description

Matter SDK has the feature, when the Commissioning window closes after some time of inactivity (15 minutes).
In this case the void OnCommissioningWindowClosed() called. But this function is also called if the Commissioning process closed the BLE session.
There is no mechanism to determine, on which reason the Commissioning window was closed.

In this pull request we can see that the call OnCommissioningWindowClosed() is adding misunderstanding at which situation was it called and forces us to make a special handling of the reason, why the window was closed. This delegate doesn't have any arguments, so we need to determine, was the session opened previously or not.

My proposal, that we need to add the argument to the delegates and forward the reason of calling this delegate.
Or we need to create a new delegate to handle the specific cases of closing the commissioning window.

Please read the conversation in the pull request to get familiar with the issue.

#26786

Platform

all

Platform Version(s)

No response

Anything else?

No response

@bzbarsky-apple
Copy link
Contributor

See also #25215 and the discussion there. We generally need to make this set of notifications sane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants