Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] mode-select-server always includes on-off-server.h, even if DEPONOFF is '0' #26252

Closed
eric-ocasio-nxp opened this issue Apr 25, 2023 · 2 comments · Fixed by #26263
Closed

Comments

@eric-ocasio-nxp
Copy link
Contributor

Reproduction steps

Create an application with mode select server and no on-off cluster. Try to build and it will fail since EMBER_AF_ON_OFF_CLUSTER_SERVER_ENDPOINT_COUNT is not defined.

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

Latest

Platform

darwin

Platform Version(s)

No response

Anything else?

I think the include of on-off-server.h should be gated, similar to what is done in emberAfModeSelectClusterServerInitCallback. I don't know if the same macro should be used, but the general idea is the same.

Dependency with On/Off is optional in the spec.

@bzbarsky-apple
Copy link
Contributor

Yes, this should probably be conditioned on EMBER_AF_PLUGIN_ON_OFF.

@eric-ocasio-nxp can you create a PR for that, since you have a way to test it?

@eric-ocasio-nxp
Copy link
Contributor Author

Done.

#26263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants