Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Fix Matter framework delegates to pass the delegating object as the first arg to their methods #22607

Closed
bzbarsky-apple opened this issue Sep 14, 2022 · 0 comments · Fixed by #22682
Assignees

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 14, 2022

Reproduction steps

The API design advice is:

Pass the delegating object as the first argument.

That said, it's not really clear to me which of our objects are "delegates" in that sense. For example, the MTRKeypair protocol really doesn't seem to fit into the "need to know the delegating object" bucket. Does the storage protocol?

Part of #22420. May have some interactions with #22542 and #22594 which rename things. And #22537 which might fix this for the pairing delegate.

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants