Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate Declaration verification need to consume real signing keys #21802

Closed
anush-apple opened this issue Aug 10, 2022 · 0 comments
Closed
Assignees
Labels
spec Mismatch between spec and implementation V1.0

Comments

@anush-apple
Copy link
Contributor

Problem

The code in GetCertificationDeclarationCertificate in DefaultDeviceAttestationVerifier.cpp is using keys that are test keys for development. We need a generic mechanism to provide a list of keys that can be given to the DA verifier, which can then be used to validate the signature of the CD.

Proposed Solution

Suggest that the CD keys for verification as provided as inputs to the DA verifier similar to how PAA keys are provided in the API and the built-in keys are used as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

No branches or pull requests

5 participants