[Crash] CHIP: chip::ChipError chip::Controller::ClusterBase::ReadAttribute<chip::Span<char const>, chip::Span<char const> >

[aajain-com]

Problem

Seeing this crash reported during testing on iOS/tvOS. This is seen as recent as TE9 SHA cfc35951be66a664a6efdadea56d1b8ea6e63e96.

Thread 1 Crashed::   Dispatch queue: com.zigbee.chip.framework.controller.workqueue
0   CHIP                          	       0x102426b30 chip::ChipError chip::Controller::ClusterBase::ReadAttribute, chip::Span >(void*, unsigned int, unsigned int, void*)(void*, chip::Span), void*)(void*, chip::ChipError), bool, chip::Optional const&) + 108
1   CHIP                          	       0x1021e06f4 __58-[CHIPBasic readAttributeVendorNameWithCompletionHandler:]_block_invoke + 108
2   CHIP                          	       0x1021e06f4 __58-[CHIPBasic readAttributeVendorNameWithCompletionHandler:]_block_invoke + 108
3   CHIP                          	       0x1023c0984 ___ZN18CHIPCallbackBridgeIPFvPvN4chip4SpanIKcEEEEC2EPU28objcproto17OS_dispatch_queue8NSObjectU13block_pointerFvP11objc_objectP7NSErrorEU13block_pointerFNS1_9ChipErrorEPNS1_8Callback10CancelableESK_ES6_b_block_invoke + 116
4   libdispatch.dylib             	       0x1bd2470f4 _dispatch_client_callout + 20
5   libdispatch.dylib             	       0x1bd256a60 _dispatch_sync_invoke_and_complete_recurse + 64
6   libdispatch.dylib             	       0x1bd2564e0 _dispatch_sync_f_slow + 172
7   CHIP                          	       0x1023c0734 CHIPCallbackBridge)>::CHIPCallbackBridge(NSObject*, void*, NSError*) block_pointer, chip::ChipError*, chip::Callback::Cancelable*) block_pointer, void*)(void*, chip::Span), bool) + 528
8   CHIP                          	       0x1021e0624 -[CHIPBasic readAttributeVendorNameWithCompletionHandler:] + 176
9   CoreFoundation                	       0x1bd57e0c4 __invoking___ + 148
10  CoreFoundation                	       0x1bd59b780 -[NSInvocation invoke] + 428
11  CoreFoundation                	       0x1bd5d0f04 -[NSInvocation invokeWithTarget:] + 64
12  CHIPPlugin                    	       0x100e08b04 -[CHIPPluginProtocolOperationManager registerOperation:clientQueue:operationResponseHandler:] + 1572
13  CHIPPlugin                    	       0x100e2fee8 -[CHIPAccessoryServer _readCharacteristicValues:forFailedResponses:atIndexes:device:completionHandler:] + 460
14  CHIPPlugin                    	       0x100e300f8 __103-[CHIPAccessoryServer _readCharacteristicValues:forFailedResponses:atIndexes:device:completionHandler:]_block_invoke + 232
15  libdispatch.dylib             	       0x1bd2455cc _dispatch_call_block_and_release + 32
16  libdispatch.dylib             	       0x1bd2470f4 _dispatch_client_callout + 20
17  libdispatch.dylib             	       0x1bd24e7ac _dispatch_lane_serial_drain + 672
18  libdispatch.dylib             	       0x1bd24f32c _dispatch_lane_invoke + 436
19  libdispatch.dylib             	       0x1bd259ebc _dispatch_workloop_worker_thread + 652
20  libsystem_pthread.dylib       	       0x2370ec040 _pthread_wqthread + 288
21  libsystem_pthread.dylib       	       0x2370ebde0 start_wqthread + 8

[aajain-com]

Marking this as P1 given that this is one of the top hitters.

[bzbarsky-apple]

It's somewhat likely that #21504 fixed this....

[franck-apple]

@aajain-com are you able to confirm?

[bzbarsky-apple]

I don't see how @aajain-com can confirm that a change that he's not able to test yet fixes anything, fwiw... ;)

[aajain-com]

I can keep an eye on this issue once we have had a chance to try with the potential fix and get back.

[andy31415]

Removed blocking tag: platform specific fix and there is some suspicion that this may already be fixed.

[woody-apple]

Resolved with: #21504