Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video device types not up to date in matter_devices.xml #19341

Closed
balloob opened this issue Jun 8, 2022 · 5 comments
Closed

Video device types not up to date in matter_devices.xml #19341

balloob opened this issue Jun 8, 2022 · 5 comments
Assignees

Comments

@balloob
Copy link
Contributor

balloob commented Jun 8, 2022

Problem

I cross-referenced device_library.pdf version 0.8-core-appclusters-devtype-ncr, 2022-05-01 21:37:45 -0700: Draft with matter_devices.xml and found the following video related items to not be up to date:

  • 10.2 Basic Video Player (0x0028) is missing from matter_devices.xml
  • 10.3 Casting video player (0x0023) is called “Video Player” in matter_devices.xml
  • 10.5 Content App is called “Content Application” in matter_devices.xml
  • 10.5 Content Application in matter_xml incorrectly references cluster TV Channel. It should be Channel.
  • 10.6 Casting Video Client is missing from matter_devices.xml
  • 10.7 Video Remote Control is missing from matter_devices.xml

Proposed Solution

Update matter_devices.xml according the latest spec.

@lazarkov
Copy link
Contributor

lazarkov commented Jun 9, 2022

hi @balloob can you please specify where can I find the matter_devices.xml?

TV Channel was renamed 6 months ago. I don't know how you're still able to find this reference

@balloob
Copy link
Contributor Author

balloob commented Jun 9, 2022

It's here:
https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/matter-devices.xml

Tip: You can press T on any GitHub page to search the files in the repository.

@naveenkommareddi
Copy link

We should label this issue with "Request Cert Blocker"

@lazarkov
Copy link
Contributor

@balloob
What should be the device id for these two?
10.6 Casting Video Client is missing from matter_devices.xml
10.7 Video Remote Control is missing from matter_devices.xml

@balloob
Copy link
Contributor Author

balloob commented Jul 20, 2022

I do not know. I just noticed that it's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants