Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoftwareVersion CLI option for OTA-P Linux app does not accept X.Y format #14865

Closed
ukatira opened this issue Feb 8, 2022 · 2 comments · Fixed by #14880
Closed

SoftwareVersion CLI option for OTA-P Linux app does not accept X.Y format #14865

ukatira opened this issue Feb 8, 2022 · 2 comments · Fixed by #14880

Comments

@ukatira
Copy link

ukatira commented Feb 8, 2022

Problem

When using SoftwareVersion CLI option for OTA-P Linux app to set any X.Y value, it only picks up and sends X in QueryImage Response
Command: chip-ota-provider-app -f test.bin -s 3.5
OTA-R trace shows:
[1644283500022] [16877:3760320] CHIP: [SWU] QueryImageResponse:
[1644283500022] [16877:3760320] CHIP: [SWU] status: 0
[1644283500022] [16877:3760320] CHIP: [SWU] delayedActionTime: 0 seconds
[1644283500022] [16877:3760320] CHIP: [SWU] imageURI: bdx://0000000000000001/test.bin
[1644283500022] [16877:3760320] CHIP: [SWU] softwareVersion: 3
[1644283500022] [16877:3760320] CHIP: [SWU] softwareVersionString: Example-Image-V0.1
[1644283500022] [16877:3760320] CHIP: [SWU] updateToken: 32
[1644283500022] [16877:3760320] CHIP: [SWU] userConsentNeeded: 0
[1644283500022] [16877:3760320] CHIP: [SWU] metadataForRequestor: 0

Proposed Solution

SoftwareVersion CLI option for OTA-P Linux app should accept any format supported by Matter

@shubhamdp
Copy link
Contributor

Ref: 11.20.6.8. QueryImageResponse Command

SoftwareVersion is of type uint32, that means only integer values are valid.

If we want something like "X.Y", then I think that should go in SoftwareVersionString.

@carol-apple
Copy link
Contributor

@shubhamdp I'm thinking one of two options here. We should either:

  1. Use the -s option for both softwareVersion and softwareVersionString (maybe just stringify 3 to "3.0")
  2. Pass in an additional command line option for the SoftwareVersionString

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants