Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cecille): This command fails on ESP32, but it's blocking IP cluster-based commissioning so for now just return a success #14158

Closed
woody-apple opened this issue Jan 25, 2022 · 3 comments

Comments

@woody-apple
Copy link
Contributor

status.


// TODO(cecille): This command fails on ESP32, but it's blocking IP cluster-based commissioning so for now just return a success
// status.
return CHIP_NO_ERROR;
}
CHIP_ERROR DeviceControlServer::ConnectNetworkForOperational(ByteSpan networkID)


This issue was generated by todo-issue based on a TODO comment in e169fcf.
@yufengwangca
Copy link
Contributor

yufengwangca commented Feb 1, 2022

It looks the ConfigurationMgr implementation for the related config flags are missing on ESP32. We should at least overwrite those config API on ESP32 platform and return CHIP_NO_ERROR there.

@jadhavrohit924
Copy link
Contributor

jadhavrohit924 commented Mar 23, 2022

Todo removed in #16520

@cecille
Copy link
Contributor

cecille commented Mar 29, 2022

Thank you!

@cecille cecille closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants