Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor controller's OpenCommissioningWindow API #12375

Closed
2 tasks
pan-apple opened this issue Nov 30, 2021 · 2 comments
Closed
2 tasks

Refactor controller's OpenCommissioningWindow API #12375

pan-apple opened this issue Nov 30, 2021 · 2 comments
Labels
stale Stale issue or PR V1.X

Comments

@pan-apple
Copy link
Contributor

This change pushes into the core communication primitives a lot of policy/choices that should be the responsibility the of client/administrator.

Changes requested:

  • Move generation of setup payload from passcode/vid/pid to the client (e.g. chip-tool as an example), since there should be one way to do it from passcode/discriminator/vid/pid in the SDK, not one for initial commissioning examples and one for commissioning window opening/
  • Do not force the reading of the VID/PID every time from basic info cluster, but rather let the caller application determine if it's needed (since many/most will actually already know VID/PID at time of openign a window). You can take the code and move it to chip tool command of open commissioning Window, to show how an application could do it if it needed.

Originally posted by @tcarmelveilleux in #11894 (review)

@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 12, 2022
@stale
Copy link

stale bot commented Oct 9, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

4 participants