Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of GetPeerAddress method in messaging/transport #11597

Closed
jepenven-silabs opened this issue Nov 9, 2021 · 2 comments
Closed

Refactor of GetPeerAddress method in messaging/transport #11597

jepenven-silabs opened this issue Nov 9, 2021 · 2 comments
Labels

Comments

@jepenven-silabs
Copy link
Contributor

Problem

All of the messaging/transport layer use GetPeerAddress to obtain the destination IP of a node in Unicast communication.
However Multicast/Group communication use the same method.

Proposed Solution

Either one of the two following solution :

  • Refactor GetPeerAddress for GetDestinationAddress that will return either a unicast IP or a multicast ip base on the context
  • Add a second method to retrieve multicast ip based on the groupID and add necessary check to choose between the two.
@stale
Copy link

stale bot commented Sep 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 5, 2022
@stale
Copy link

stale bot commented Sep 22, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants