From f8f71645572dc9923bd7f0d3570c0805be1b93e3 Mon Sep 17 00:00:00 2001 From: Shubham Patil Date: Thu, 3 Aug 2023 08:31:35 +0530 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tennessee Carmel-Veilleux --- src/protocols/secure_channel/CASEServer.h | 2 +- src/protocols/secure_channel/StatusReport.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/protocols/secure_channel/CASEServer.h b/src/protocols/secure_channel/CASEServer.h index bb47460e26e972..0c1f1d26dcb963 100644 --- a/src/protocols/secure_channel/CASEServer.h +++ b/src/protocols/secure_channel/CASEServer.h @@ -111,7 +111,7 @@ class CASEServer : public SessionEstablishmentDelegate, // If we are in the middle of handshake and receive a Sigma1 then respond with Busy status code. // @param[in] ec Exchange Context - // @param[in] minimumWaitTime Minimum wait time before client resends sigma1 + // @param[in] minimumWaitTime Minimum wait time reported to client before it can attempt to resend sigma1 // // @return CHIP_NO_ERROR on success, error code otherwise CHIP_ERROR SendBusyStatusReport(Messaging::ExchangeContext * ec, System::Clock::Milliseconds16 minimumWaitTime); diff --git a/src/protocols/secure_channel/StatusReport.cpp b/src/protocols/secure_channel/StatusReport.cpp index 129759d19c16f9..e31c832b469f51 100644 --- a/src/protocols/secure_channel/StatusReport.cpp +++ b/src/protocols/secure_channel/StatusReport.cpp @@ -112,7 +112,7 @@ System::PacketBufferHandle StatusReport::MakeBusyStatusReportMessage(System::Clo ChipLogError(SecureChannel, "Failed to finalize protocol data for busy status report")); // Build a busy status report - StatusReport statusReport(GeneralStatusCode::kBusy, Id, kProtocolCodeBusy, std::move(handle)); + StatusReport statusReport(GeneralStatusCode::kBusy, Protocols::SecureChannel::Id, kProtocolCodeBusy, std::move(handle)); // Build the status report message handle = System::PacketBufferHandle::New(statusReport.Size());