From 63e2099c254c7d85da53c1d18561bdf5712a5231 Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Fri, 8 Nov 2024 11:06:42 -0500 Subject: [PATCH] Update one more ifdef surround: if no extra logging, remove a larger code chunk --- src/app/reporting/Engine.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/reporting/Engine.cpp b/src/app/reporting/Engine.cpp index 55a33cb44e5459..ea4c0014e71397 100644 --- a/src/app/reporting/Engine.cpp +++ b/src/app/reporting/Engine.cpp @@ -109,16 +109,16 @@ DataModel::ActionReturnStatus RetrieveClusterData(DataModel::Provider * dataMode *encoderState = attributeValueEncoder.GetState(); } +#if CHIP_CONFIG_DATA_MODEL_EXTRA_LOGGING // Out of space errors may be chunked data, reporting those cases would be very confusing // as they are not fully errors. Report only others (which presumably are not recoverable // and will be sent to the client as well). if (!status.IsOutOfSpaceEncodingResponse()) { DataModel::ActionReturnStatus::StringStorage storage; -#if CHIP_CONFIG_DATA_MODEL_EXTRA_LOGGING ChipLogError(DataManagement, "Failed to read attribute: %s", status.c_str(storage)); -#endif } +#endif return status; }