From 42fc1fcc26795726b44febaa89cc8a24b4274659 Mon Sep 17 00:00:00 2001 From: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Date: Wed, 11 Oct 2023 14:53:49 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> --- src/app/clusters/scenes-server/scenes-server.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/app/clusters/scenes-server/scenes-server.cpp b/src/app/clusters/scenes-server/scenes-server.cpp index dd81b12b163448..00af3d901046f5 100644 --- a/src/app/clusters/scenes-server/scenes-server.cpp +++ b/src/app/clusters/scenes-server/scenes-server.cpp @@ -136,7 +136,6 @@ CHIP_ERROR ScenesServer::Init() ChipLogDetail(Zcl, "ERR: getting the scenes FeatureMap on Endpoint %hu Status: %x", endpoint, status); } - // Forcing matter mandatory features on // Explicit AttributeValuePairs is mandatory for matter so we force it here featureMap |= to_underlying(Feature::kExplicit); status = Attributes::FeatureMap::Set(endpoint, featureMap); @@ -212,7 +211,7 @@ void AddSceneParse(CommandHandlerInterface::HandlerContext & ctx, const CommandD uint8_t EFSCount = 0; - uint32_t featureMap = 0x00; + uint32_t featureMap = 0; ReturnOnFailure(AddResponseOnError(ctx, response, Attributes::FeatureMap::Get(ctx.mRequestPath.mEndpointId, &featureMap))); SceneData storageData(CharSpan(), transitionTimeMs); @@ -394,7 +393,7 @@ CHIP_ERROR StoreSceneParse(const FabricIndex & fabricIdx, const EndpointId & end } else { - uint32_t featureMap = 0x00; + uint32_t featureMap = 0; ReturnErrorOnFailure( StatusIB(ToInteractionModelStatus(Attributes::FeatureMap::Get(endpointID, &featureMap))).ToChipError()); // Check if we still support scenes name in case an OTA changed that, if we don't, set name to empty