From 1228795aa8b016e532968b08a43ad43b185b1b98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Damian=20Kr=C3=B3lik?= <66667989+Damian-Nordic@users.noreply.github.com> Date: Mon, 24 Jan 2022 18:27:21 +0100 Subject: [PATCH] [mrp] Inline ReliableMessageContext getters and setters (#13865) These are very simple methods, so inlining them reduces the code size. --- src/messaging/ReliableMessageContext.cpp | 55 ------------------------ src/messaging/ReliableMessageContext.h | 55 ++++++++++++++++++++++++ 2 files changed, 55 insertions(+), 55 deletions(-) diff --git a/src/messaging/ReliableMessageContext.cpp b/src/messaging/ReliableMessageContext.cpp index 62f1bd75531975..6ee0a9882cd07f 100644 --- a/src/messaging/ReliableMessageContext.cpp +++ b/src/messaging/ReliableMessageContext.cpp @@ -41,56 +41,6 @@ namespace Messaging { ReliableMessageContext::ReliableMessageContext() : mNextAckTime(0), mPendingPeerAckMessageCounter(0) {} -bool ReliableMessageContext::AutoRequestAck() const -{ - return mFlags.Has(Flags::kFlagAutoRequestAck); -} - -bool ReliableMessageContext::IsAckPending() const -{ - return mFlags.Has(Flags::kFlagAckPending); -} - -bool ReliableMessageContext::HasRcvdMsgFromPeer() const -{ - return mFlags.Has(Flags::kFlagMsgRcvdFromPeer); -} - -void ReliableMessageContext::SetAutoRequestAck(bool autoReqAck) -{ - mFlags.Set(Flags::kFlagAutoRequestAck, autoReqAck); -} - -void ReliableMessageContext::SetMsgRcvdFromPeer(bool inMsgRcvdFromPeer) -{ - mFlags.Set(Flags::kFlagMsgRcvdFromPeer, inMsgRcvdFromPeer); -} - -void ReliableMessageContext::SetAckPending(bool inAckPending) -{ - mFlags.Set(Flags::kFlagAckPending, inAckPending); -} - -void ReliableMessageContext::SetDropAckDebug(bool inDropAckDebug) -{ - mFlags.Set(Flags::kFlagDropAckDebug, inDropAckDebug); -} - -bool ReliableMessageContext::IsMessageNotAcked() const -{ - return mFlags.Has(Flags::kFlagMesageNotAcked); -} - -void ReliableMessageContext::SetMessageNotAcked(bool messageNotAcked) -{ - mFlags.Set(Flags::kFlagMesageNotAcked, messageNotAcked); -} - -bool ReliableMessageContext::ShouldDropAckDebug() const -{ - return mFlags.Has(Flags::kFlagDropAckDebug); -} - ExchangeContext * ReliableMessageContext::GetExchangeContext() { return static_cast(this); @@ -121,11 +71,6 @@ CHIP_ERROR ReliableMessageContext::FlushAcks() return err; } -bool ReliableMessageContext::HasPiggybackAckPending() const -{ - return mFlags.Has(Flags::kFlagAckMessageCounterIsValid); -} - /** * Process received Ack. Remove the corresponding message context from the RetransTable and execute the application * callback diff --git a/src/messaging/ReliableMessageContext.h b/src/messaging/ReliableMessageContext.h index 68e05979cac0d1..ed4a05b0657afd 100644 --- a/src/messaging/ReliableMessageContext.h +++ b/src/messaging/ReliableMessageContext.h @@ -228,5 +228,60 @@ class ReliableMessageContext uint32_t mPendingPeerAckMessageCounter; }; +inline bool ReliableMessageContext::AutoRequestAck() const +{ + return mFlags.Has(Flags::kFlagAutoRequestAck); +} + +inline bool ReliableMessageContext::IsAckPending() const +{ + return mFlags.Has(Flags::kFlagAckPending); +} + +inline bool ReliableMessageContext::HasRcvdMsgFromPeer() const +{ + return mFlags.Has(Flags::kFlagMsgRcvdFromPeer); +} + +inline bool ReliableMessageContext::IsMessageNotAcked() const +{ + return mFlags.Has(Flags::kFlagMesageNotAcked); +} + +inline bool ReliableMessageContext::ShouldDropAckDebug() const +{ + return mFlags.Has(Flags::kFlagDropAckDebug); +} + +inline bool ReliableMessageContext::HasPiggybackAckPending() const +{ + return mFlags.Has(Flags::kFlagAckMessageCounterIsValid); +} + +inline void ReliableMessageContext::SetAutoRequestAck(bool autoReqAck) +{ + mFlags.Set(Flags::kFlagAutoRequestAck, autoReqAck); +} + +inline void ReliableMessageContext::SetMsgRcvdFromPeer(bool inMsgRcvdFromPeer) +{ + mFlags.Set(Flags::kFlagMsgRcvdFromPeer, inMsgRcvdFromPeer); +} + +inline void ReliableMessageContext::SetAckPending(bool inAckPending) +{ + mFlags.Set(Flags::kFlagAckPending, inAckPending); +} + +inline void ReliableMessageContext::SetDropAckDebug(bool inDropAckDebug) +{ + mFlags.Set(Flags::kFlagDropAckDebug, inDropAckDebug); +} + +inline void ReliableMessageContext::SetMessageNotAcked(bool messageNotAcked) +{ + mFlags.Set(Flags::kFlagMesageNotAcked, messageNotAcked); +} + } // namespace Messaging } // namespace chip