Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples for rounded corners don't include sizing variables #620

Closed
trosage opened this issue Dec 4, 2018 · 2 comments
Closed

Examples for rounded corners don't include sizing variables #620

trosage opened this issue Dec 4, 2018 · 2 comments

Comments

@trosage
Copy link
Contributor

trosage commented Dec 4, 2018 •
edited
Loading

The documentation for rounded corners for sides don't currently include the sizing variables so they don't actually work as shown in the example (the examples just show square corners too). They currently just show .rounded-left rather than .rounded-left-1

This can be reproduced here:
https://styleguide.github.com/primer/utilities/borders/#rounded-corners

image
@shawnbot
Copy link
Contributor

shawnbot commented Dec 5, 2018

Sorry about this, @trosage! This was actually fixed in #614, but I haven't deployed the patch release to the style guide yet. I'm going to do that ASAP, and will update you here when that's done.

@shawnbot
Copy link
Contributor

Fixed in #614, deploying to the style guide shortly! 🎅 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawnbot @trosage